mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Prezeroing V8
Date: Thu, 17 Mar 2005 16:17:52 -0800	[thread overview]
Message-ID: <20050317161752.761fe8e9.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0503171600320.10205@schroedinger.engr.sgi.com>

Christoph Lameter <clameter@sgi.com> wrote:
>
> On Thu, 17 Mar 2005, Andrew Morton wrote:
> 
> > >  http://oss.sgi.com/projects/page_fault_performance/
> >
> > Oh no, not that page again ;)
> 
> Yes indeed!
> 
> > Seems to say that prezeroing makes negligible difference to kernel builds,
> > but speeds up a big malloc+memset by 3x to 4x, yes?
> 
> Correct.
> 
> > Are there any real-worldish workloads which show an appreciable benefit?
> 
> Ummm. Big loads are our real-worldish workloads here.

Sure, but not malloc+memset+exit.

How much improvement do these big numerical tasks get from the patch?

> > The large speedup for a big memset seems odd - I assume it's simply
> > transferring CPU load from the user's process over to kscrubd.  Or is it
> > the fancy page-zeroing hardware?  How do we differentiate the two?
> 
> I switched off the page-zeroing hardware for the tests.

What tests?

See, a speedup in a simple malloc+memset could be due to either a simple
transfer of load from user to kscrubd, or it could be due to leveraging the
page-zeroing hardware.

The latter, I expect, if the workload is actually touching every byte of
all the pages.  Is it?

If we're doing kscrubd zeroing via memset() then the total system load
would actually be increased if the application is touching every byte, yes?

> > Are there any workloads which are seeing a benefit on a CPU which doesn't
> > have the zeroing hardware?
> 
> Without zeroing hardware the eroing actions are moved to idle
> system time (load < /proc/sys/vm/scrub_load). Its shifting the cpu load.

Right.  We'd expect that to be a net regression if the application is
touching all of the memory and a net win if it is touching the memory
sparsely, yes?



  reply	other threads:[~2005-03-18  0:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-17 21:43 Christoph Lameter
2005-03-17 22:08 ` Andrew Morton
2005-03-17 22:31   ` Christoph Lameter
2005-03-17 23:11     ` Andrew Morton
2005-03-17 23:24       ` Christoph Lameter
2005-03-17 23:52         ` Andrew Morton
2005-03-18  0:00           ` Christoph Lameter
2005-03-17 23:26       ` Christoph Lameter
2005-03-17 23:59         ` Andrew Morton
2005-03-18  0:04           ` Christoph Lameter
2005-03-18  0:17             ` Andrew Morton [this message]
2005-03-18  0:29               ` Christoph Lameter
2005-03-18  1:36   ` [PATCH] Prezeroing V8 + free_hot_zeroed_page + free_cold_zeroed page Christoph Lameter
2005-03-18  2:06     ` Jason Uhlenkott
2005-03-18  2:09       ` Christoph Lameter
2005-03-18  5:43         ` Nish Aravamudan
2005-03-17 22:59 ` [PATCH] Prezeroing V8 Nish Aravamudan
2005-03-17 23:06   ` Christoph Lameter
2005-03-18  3:14     ` Benjamin Herrenschmidt
2005-03-25  1:44 ` Pavel Machek
2005-03-25 12:28   ` Jan Engelhardt
2005-03-29  1:50   ` [PATCH] " Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050317161752.761fe8e9.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome