mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Matt Dainty <matt@bodgit-n-scarper.com>
Cc: linux-kernel@vger.kernel.org, Erich Chen <erich@areca.com.tw>
Subject: Re: Building Areca arcmsr driver outside kernel source tree
Date: Sun, 20 Mar 2005 09:40:52 +0000	[thread overview]
Message-ID: <20050320094052.GA12363@infradead.org> (raw)
In-Reply-To: <1111258047.3746.45.camel@lister.bodgit-n-scarper.com>

On Sat, Mar 19, 2005 at 06:47:27PM +0000, Matt Dainty wrote:
> To get the arcmsr driver working with CentOS/RHEL 4 and using the
> facility to build kernel modules outside of the kernel source tree, I
> found the attached patch was necessary to remove the dependencies on the
> internal drivers/scsi/scsi*.h header files and to instead use the public
> ones found under include/scsi/ which are provided by the kernel-*-devel
> packages.
> 
> It builds, loads and appears to work with my limited testing on an
> ARC1120. I was just wanting to know if this was the right way to fix it?
> Once the driver is in the main kernel tree it's largely irrelevant, but
> while CentOS/RHEL 4 use the older kernel without the driver it's a PITA
> to maintain kernel packages with this one driver added, when a separate
> package containing just the driver is much easier.
> 
> The patch is based on the 1.20.00.06 driver that was added to
> 2.6.11-mm4.

Patch looks good, scsi.h is deprecated for a long time and I told
Erich to stop using it already.


      reply	other threads:[~2005-03-20  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-19 18:47 Matt Dainty
2005-03-20  9:40 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050320094052.GA12363@infradead.org \
    --to=hch@infradead.org \
    --cc=erich@areca.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@bodgit-n-scarper.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®