Re: 2.6.11-rc4: Alps touchpad too slow

[Andrew Morton <akpm@osdl.org>]

Andy Isaacson <adi@hexapodia.org> wrote:
>
> On Mon, Mar 21, 2005 at 02:44:12PM -0800, Andrew Morton wrote:
> > Andy Isaacson <adi@hexapodia.org> wrote:
> > > My Vaio r505te comes up with an unusably slow touchpad if I allow the
> > > ALPS driver to drive it.  It says
> > > 
> > > > ALPS Touchpad (Glidepoint) detected
> > > >   Disabling hardware tapping
> > > > input: AlpsPS/2 ALPS TouchPad on isa0060/serio1
> > > 
> > > and then the trackpad operates at about 1/8 the speed I've gotten used
> > > to. ...  2.6.11-rc4 ...
> > 
> > Andy, could you please test 2.6.12-rc1 and let us know which problems
> > remain?
> 
> With cvsbk rev 423b66b6oJOGN68OhmSrBFxxLOtIEA (rsynced Monday, it claims
> to be "2.6.12-rc1"), the situation is much improved.  The AlpsPS/2
> driver recognizes the trackpad, tracking speed is back to normal, and
> tapping is turned on by default.  (Drat, now I need to figure out how to
> turn that off again.)

Wonderful, thanks.

> The kernel output is a bit odd, though:
> 
> [ 1200.254707] Adding 987988k swap on /dev/hda3.  Priority:-1 extents:1
> [ 1200.330453] EXT3 FS on hda2, internal journal
> [ 1203.504154] SCSI subsystem initialized
> [ 1204.039053]   Enabling hardware tapping
> [ 1204.099034] ieee1394: Initialized config rom entry `ip1394'
> [ 1204.266077] input: PS/2 Mouse on isa0060/serio1
> [ 1204.400583] input: AlpsPS/2 ALPS GlidePoint on isa0060/serio1
> [ 1204.779799] sbp2: $Rev: 1219 $ Ben Collins <bcollins@debian.org>
> [ 1206.183165] kjournald starting.  Commit interval 5 seconds
> 
> Note how the "Enabling hardware tapping" message is several lines
> earlier than it seems it should be... I don't think I'm supposed to be
> tapping on my SCSI hardware.
> 
> ... ah, I think I'm missing the "ALPS GlidePoint detected" message which
> I used to get.  Without it, the "Enabling hardware tapping" message is a
> bit opaque.

Yes, alps_init() had a printk removed and now the output looks funny.



diff -puN drivers/input/mouse/alps.c~alps-printk-tidy drivers/input/mouse/alps.c
--- 25/drivers/input/mouse/alps.c~alps-printk-tidy	2005-03-21 22:23:46.000000000 -0800
+++ 25-akpm/drivers/input/mouse/alps.c	2005-03-21 22:23:53.000000000 -0800
@@ -395,7 +395,7 @@ int alps_init(struct psmouse *psmouse)
 	}
 
 	if (param[0] & 0x04) {
-		printk(KERN_INFO "  Enabling hardware tapping\n");
+		printk(KERN_INFO "alps.c: Enabling hardware tapping\n");
 		if (alps_tap_mode(psmouse, 1))
 			printk(KERN_WARNING "alps.c: Failed to enable hardware tapping\n");
 	}
_