From: "David S. Miller" <davem@davemloft.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] drivers/net/tg3.c: remove dead code
Date: Tue, 22 Mar 2005 14:08:57 -0800 [thread overview]
Message-ID: <20050322140857.34c55ce6.davem@davemloft.net> (raw)
In-Reply-To: <20050322220243.GQ1948@stusta.de>
On Tue, 22 Mar 2005 23:02:43 +0100
Adrian Bunk <bunk@stusta.de> wrote:
> The Coverity checker discovered that i never gets any value different
> from 0 assigned.
>
> I do not claim that this patch is correct, but if it isn't correct the
> bug is that i never gets assigned any value.
Indeed, 'i' needs to be incremented at the end of the loop
basic block.
Good catch.
prev parent reply other threads:[~2005-03-22 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 22:02 Adrian Bunk
2005-03-22 22:08 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050322140857.34c55ce6.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®