From: Blaisorblade <blaisorblade@yahoo.it>
To: Roman Zippel <zippel@linux-m68k.org>, kbuild-devel@lists.sourceforge.net
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Bug with multiple help messages, the last one is shown
Date: Tue, 22 Mar 2005 18:32:41 +0100 [thread overview]
Message-ID: <200503221832.41883.blaisorblade@yahoo.it> (raw)
I've verified multiple times that if we have a situation like this
bool A
depends on TRUE
help
Bla bla1
and
bool A
depends on FALSE
help
Bla bla2
even if the first option is the displayed one, the help text used is the one
for the second option (the absence of "prompt" is not relevant here)!
>From a very short reading of sources, I guess that the problem is probably
located in this line (from scripts/kconfig/zconf.y):
help: help_start T_HELPTEXT
{
current_entry->sym->help = $2;
};
because the various current_entry values (matching the various definitions)
share the same symbol (since of the sym_lookup call below)
config_entry_start: T_CONFIG T_WORD T_EOL
{
struct symbol *sym = sym_lookup($2, 0);
sym->flags |= SYMBOL_OPTIONAL;
menu_add_entry(sym);
printd(DEBUG_PARSE, "%s:%d:config %s\n", zconf_curname(),
zconf_lineno(), $2);
};
Now, Kconfig handles well the same situation when there are multiple different
prompts, instead of multiple help texts.
This because the "prompt" is added as a property with its own dependency; why
is not this done for "help", too?
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
next reply other threads:[~2005-03-22 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 17:32 Blaisorblade [this message]
2005-03-22 20:00 ` Roman Zippel
2005-04-05 17:36 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503221832.41883.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®