From: Andrew Morton <akpm@osdl.org>
To: jason@stdbev.com, linux-kernel@vger.kernel.org, elenstev@mesatop.com
Subject: Re: 2.6.12-rc1-mm3 (cannot read cd-rom, 2.6.12-rc1 is OK)
Date: Fri, 25 Mar 2005 14:23:36 -0800 [thread overview]
Message-ID: <20050325142336.12687e09.akpm@osdl.org> (raw)
In-Reply-To: <20050325140654.430714e2.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
>
> It's the new rock-ridge bounds checking.
Try this, please?
diff -puN fs/isofs/rock.c~rock-handle-directory-overflows-fix fs/isofs/rock.c
--- 25/fs/isofs/rock.c~rock-handle-directory-overflows-fix Fri Mar 25 14:21:32 2005
+++ 25-akpm/fs/isofs/rock.c Fri Mar 25 14:22:01 2005
@@ -218,12 +218,12 @@ repeat:
if (rr->len < 3)
goto out; /* Something got screwed up here */
sig = isonum_721(rs.chr);
+ if (rock_check_overflow(&rs, sig))
+ goto eio;
rs.chr += rr->len;
rs.len -= rr->len;
if (rs.len < 0)
goto eio; /* corrupted isofs */
- if (rock_check_overflow(&rs, sig))
- goto eio;
switch (sig) {
case SIG('R', 'R'):
@@ -316,12 +316,12 @@ repeat:
if (rr->len < 3)
goto out; /* Something got screwed up here */
sig = isonum_721(rs.chr);
+ if (rock_check_overflow(&rs, sig))
+ goto eio;
rs.chr += rr->len;
rs.len -= rr->len;
if (rs.len < 0)
goto eio; /* corrupted isofs */
- if (rock_check_overflow(&rs, sig))
- goto eio;
switch (sig) {
#ifndef CONFIG_ZISOFS /* No flag for SF or ZF */
@@ -694,12 +694,12 @@ repeat:
if (rr->len < 3)
goto out; /* Something got screwed up here */
sig = isonum_721(rs.chr);
+ if (rock_check_overflow(&rs, sig))
+ goto out;
rs.chr += rr->len;
rs.len -= rr->len;
if (rs.len < 0)
goto out; /* corrupted isofs */
- if (rock_check_overflow(&rs, sig))
- goto out;
switch (sig) {
case SIG('R', 'R'):
_
next prev parent reply other threads:[~2005-03-25 22:24 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 8:21 2.6.12-rc1-mm3 Andrew Morton
2005-03-25 10:46 ` 2.6.12-rc1-mm3 Brice Goglin
2005-03-25 11:29 ` 2.6.12-rc1-mm3: box hangs solid on resume from disk while resuming device drivers Rafael J. Wysocki
2005-05-02 22:54 ` Andrew Morton
2005-05-03 19:34 ` Rafael J. Wysocki
2005-03-25 16:46 ` 2.6.12-rc1-mm3 Borislav Petkov
2005-03-31 13:05 ` 2.6.12-rc1-mm3 Borislav Petkov
2005-03-31 20:11 ` 2.6.12-rc1-mm3 Andrew Morton
2005-03-31 20:57 ` 2.6.12-rc1-mm3 Borislav Petkov
2005-03-25 18:17 ` 2.6.12-rc1-mm3 Barry K. Nathan
2005-03-25 19:50 ` 2.6.12-rc1-mm3 (cannot read cd-rom, 2.6.12-rc1 is OK) Steven Cole
2005-03-25 20:17 ` Steven Cole
2005-03-25 20:24 ` Andrew Morton
2005-03-25 21:22 ` Steven Cole
2005-03-25 21:49 ` Andrew Morton
2005-03-25 22:31 ` Steven Cole
2005-03-25 21:49 ` Jason Munro
2005-03-25 22:06 ` Andrew Morton
2005-03-25 22:23 ` Andrew Morton [this message]
2005-03-25 22:43 ` Steven Cole
2005-03-25 22:43 ` Jason Munro
2005-03-25 22:58 ` Andrew Morton
2005-03-25 22:27 ` Chris Wright
2005-03-25 22:27 ` Jason Munro
2005-03-25 22:30 ` Jason Munro
2005-03-26 1:43 ` 2.6.12-rc1-mm3 Jason Uhlenkott
2005-03-26 1:56 ` [ACPI] 2.6.12-rc1-mm3 Len Brown
2005-03-26 2:02 ` Jason Uhlenkott
2005-03-26 2:24 ` Len Brown
2005-03-26 2:57 ` Jason Uhlenkott
2005-03-26 3:40 ` Jesse Barnes
2005-03-26 4:12 ` Len Brown
2005-03-26 5:52 ` Jason Uhlenkott
2005-03-26 10:19 ` 2.6.12-rc1-mm3, sound card lost id Jean Delvare
2005-03-29 12:24 ` [Alsa-devel] " Takashi Iwai
2005-03-29 17:57 ` Jean Delvare
2005-03-29 20:17 ` Lee Revell
2005-03-29 20:46 ` Jean Delvare
2005-03-29 20:52 ` Lee Revell
2005-03-29 21:13 ` Jean Delvare
2005-03-29 21:18 ` Lee Revell
2005-03-30 12:24 ` Takashi Iwai
2005-03-26 19:39 ` PCMCIA Oops (was Re: 2.6.12-rc1-mm3) Sean Neakums
2005-03-26 22:00 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050325142336.12687e09.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=elenstev@mesatop.com \
--cc=jason@stdbev.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®