From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Li, Shaohua" <shaohua.li@intel.com>, "Andrew Morton" <akpm@osdl.org>
Cc: "Brown, Len" <len.brown@intel.com>,
linux-kernel@vger.kernel.org, "Pavel Machek" <pavel@suse.cz>
Subject: Re: 2.6.12-rc1-mm3: box hangs solid on resume from disk while resuming device drivers
Date: Fri, 25 Mar 2005 15:19:22 +0100 [thread overview]
Message-ID: <200503251519.22680.rjw@sisk.pl> (raw)
In-Reply-To: <16A54BF5D6E14E4D916CE26C9AD30575017EDC38@pdsmsx402.ccr.corp.intel.com>
Hi,
On Friday, 25 of March 2005 13:54, you wrote:
]--snip--[
> >My box is still hanged solid on resume (swsusp) by the drivers:
> >
> >ohci_hcd
> >ehci_hcd
> >yenta_socket
> >
> >possibly others, too. To avoid this, I had to revert the following
> patch from the Len's tree:
> >
> >diff -Naru a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> >--- a/drivers/acpi/pci_link.c 2005-03-24 04:57:27 -08:00
> >+++ b/drivers/acpi/pci_link.c 2005-03-24 04:57:27 -08:00
> >@@ -72,10 +72,12 @@
> > u8 active; /* Current IRQ
> */
> > u8 edge_level; /* All IRQs */
> > u8 active_high_low; /* All IRQs */
> >- u8 initialized;
> > u8 resource_type;
> > u8 possible_count;
> > u8 possible[ACPI_PCI_LINK_MAX_POSSIBLE];
> >+ u8 initialized:1;
> >+ u8 suspend_resume:1;
> >+ u8 reserved:6;
> > };
> >
> > struct acpi_pci_link {
> >@@ -530,6 +532,10 @@
> >
> > ACPI_FUNCTION_TRACE("acpi_pci_link_allocate");
> >
> >+ if (link->irq.suspend_resume) {
> >+ acpi_pci_link_set(link, link->irq.active);
> >+ link->irq.suspend_resume = 0;
> >+ }
> > if (link->irq.initialized)
> > return_VALUE(0);
>
> How about just remove below line:
> >+ acpi_pci_link_set(link, link->irq.active);
You mean apply the patch again and remove just the single
line? No effect (ie hangs).
Greets,
Rafael
--
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
-- Lewis Carroll "Alice's Adventures in Wonderland"
next prev parent reply other threads:[~2005-03-25 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 12:54 Li, Shaohua
2005-03-25 14:19 ` Rafael J. Wysocki [this message]
2005-03-26 18:23 ` Rafael J. Wysocki
2005-03-26 19:07 ` Rafael J. Wysocki
2005-03-28 1:22 ` Li Shaohua
2005-03-29 10:33 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2005-03-25 8:21 2.6.12-rc1-mm3 Andrew Morton
2005-03-25 11:29 ` 2.6.12-rc1-mm3: box hangs solid on resume from disk while resuming device drivers Rafael J. Wysocki
2005-05-02 22:54 ` Andrew Morton
2005-05-03 19:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503251519.22680.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®