mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Brett Russ <russb@emc.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH libata-dev-2.6] libata: flush COMRESET write
Date: Fri, 25 Mar 2005 18:19:07 -0500 (EST)	[thread overview]
Message-ID: <20050325231907.E1D11BADC@lns1032.lss.emc.com> (raw)

Jeff,

I'm seeing single drives getting stuck in ata_busy_sleep() with these
log messages on boot:

<4>ata2 is slow to respond, please be patient
<3>ata2 failed to respond (30 secs)

One thing I found was the bug fixed below, where the COMRESET wasn't
getting flushed properly.  This may or may not be the reason, but it
can't hurt.  I have to keep looking and testing.

I wanted to also send a separate patch to ensure the port was stopped
before issuing COMRESET, since this is required by at least the ICH6R,
but the port_stop() routines seemed too heavy to call from
__sata_phy_reset() so I'm not sending anything like that yet.

Signed-off-by: Brett Russ <russb@emc.com>

Index: libata-dev-2.6/drivers/scsi/libata-core.c
===================================================================
--- libata-dev-2.6.orig/drivers/scsi/libata-core.c	2005-03-23 16:44:48.000000000 -0500
+++ libata-dev-2.6/drivers/scsi/libata-core.c	2005-03-25 16:58:22.000000000 -0500
@@ -1262,7 +1262,7 @@
 
 	if (ap->flags & ATA_FLAG_SATA_RESET) {
 		scr_write(ap, SCR_CONTROL, 0x301); /* issue phy wake/reset */
-		scr_read(ap, SCR_STATUS);	/* dummy read; flush */
+		scr_read(ap, SCR_CONTROL);	/* dummy read; flush */
 		udelay(400);			/* FIXME: a guess */
 	}
 	scr_write(ap, SCR_CONTROL, 0x300);	/* issue phy wake/clear reset */

             reply	other threads:[~2005-03-25 23:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-25 23:19 Brett Russ [this message]
2005-03-28 20:10 ` [PATCH libata-2.6] libata: flush COMRESET set and clear Brett Russ
2005-05-15 23:01   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050325231907.E1D11BADC@lns1032.lss.emc.com \
    --to=russb@emc.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®