From: Chris Wedgwood <cw@f00f.org>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@oss.sgi.com, from-linux-kernel@I-love.sakura.ne.jp
Subject: Re: Off-by-one bug at unix_mkname ?
Date: Mon, 28 Mar 2005 00:49:53 -0800 [thread overview]
Message-ID: <20050328084953.GA3712@taniwha.stupidest.org> (raw)
In-Reply-To: <20050328.173938.26746686.yoshfuji@linux-ipv6.org>
On Mon, Mar 28, 2005 at 05:39:38PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> + /*
> + * This may look like an off by one error but it is
> + * a bit more subtle. 108 is the longest valid AF_UNIX
> + * path for a binding. sun_path[108] doesnt as such
> + * exist. However in kernel space we are guaranteed that
> + * it is a valid memory location in our kernel
> + * address buffer.
icky pointless white space?
> + */
> + if (len > sizeof(*sunaddr))
what?
next prev parent reply other threads:[~2005-03-28 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 8:00 Tetsuo Handa
2005-03-28 8:12 ` Willy Tarreau
2005-03-28 8:21 ` YOSHIFUJI Hideaki / 吉藤英明
2005-03-28 8:39 ` YOSHIFUJI Hideaki / 吉藤英明
2005-03-28 8:48 ` YOSHIFUJI Hideaki / 吉藤英明
2005-03-28 8:52 ` Tetsuo Handa
2005-03-28 8:49 ` Chris Wedgwood [this message]
[not found] ` <Pine.LNX.4.61.0503281124450.18443@yvahk01.tjqt.qr>
2005-03-28 9:33 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328084953.GA3712@taniwha.stupidest.org \
--to=cw@f00f.org \
--cc=davem@davemloft.net \
--cc=from-linux-kernel@I-love.sakura.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®