From: Chris Wright <chrisw@osdl.org>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Chris Wright <chrisw@osdl.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] isofs: unobfuscate rock.c
Date: Mon, 28 Mar 2005 14:46:34 -0800 [thread overview]
Message-ID: <20050328224634.GO30522@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050328223048.GA2741@pclin040.win.tue.nl>
* Andries Brouwer (aebr@win.tue.nl) wrote:
> On Mon, Mar 28, 2005 at 12:02:52PM -0800, Chris Wright wrote:
> > * Pekka Enberg (penberg@cs.helsinki.fi) wrote:
> > > This patch removes macro obfuscation from fs/isofs/rock.c and cleans it up
> > > a bit to make it more readable and maintainable. There are no functional
> > > changes, only cleanups. I have only tested this lightly but it passes
> > > mount and read on small Rock Ridge enabled ISO image.
> >
> > You might want to look at current -mm. Andrew has a series or 13 or so
> > patches that do very similar cleanup. Perhaps you could start from there?
>
> Good! When Linus asked I audited rock.c and also did rather similar polishing -
> it happens automatically if one looks at this code. But it seems everybody is
> doing this right now, so I must wait a few weeks and see what got into Linus'
> tree. Linus plugged many but not all holes. (Maybe you did more?)
I plugged one more (in 2.6.11.6 and in Linus' tree), and Andrew plugged
yet another (last patch in his iso/rock cleanup series). More eyes
the better.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2005-03-28 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 17:41 Pekka Enberg
2005-03-28 17:41 ` [PATCH 1/9] isofs: indent rock.c Pekka Enberg
2005-03-28 17:41 ` [PATCH 2/9] isofs: inline macros in rock.c Pekka Enberg
2005-03-28 17:41 ` [PATCH 3/9] " Pekka Enberg
2005-03-28 17:41 ` [PATCH 4/9] " Pekka Enberg
2005-03-28 17:41 ` [PATCH 5/9] isofs: convert macro to function " Pekka Enberg
2005-03-28 17:42 ` [PATCH 6/9] " Pekka Enberg
2005-03-28 17:42 ` [PATCH 7/9] isofs: extract zisofs parsing to function Pekka Enberg
2005-03-28 17:42 ` [PATCH 8/9] isofs: remove redundant kfree checks from rock Pekka Enberg
2005-03-28 17:42 ` [PATCH 9/9] isofs: clean up rock.c Pekka Enberg
2005-03-28 20:02 ` [PATCH 0/9] isofs: unobfuscate rock.c Chris Wright
2005-03-28 22:30 ` Andries Brouwer
2005-03-28 22:46 ` Chris Wright [this message]
2005-03-29 6:22 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328224634.GO30522@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=aebr@win.tue.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®