mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: <axboe@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: [patch] new fifo I/O elevator that really does nothing at all
Date: Mon, 28 Mar 2005 17:48:21 -0800	[thread overview]
Message-ID: <200503290148.j2T1mOg25279@unix-os.sc.intel.com> (raw)

The noop elevator is still too fat for db transaction processing workload.
Since the db application already merged all blocks before sending it down,
the I/O presented to the elevator are actually not merge-able anymore. Since
I/O are also random, we don't want to sort them either.  However the noop
elevator is still doing a linear search on the entire list of requests in
the queue.  A noop elevator after all isn't really noop.

We are proposing a true no-op elevator algorithm, no merge, no nothing. Just
do first in and first out list management for the I/O request.  The best name
I can come up with is "FIFO".  I also piggy backed the code onto noop-iosched.c.
I can easily pull those code into a separate file if people object.  Though, I
hope Jens is OK with it.


--- linux-2.6.11/drivers/block/noop-iosched.c.orig	2005-03-28 16:37:30.000000000 -0800
+++ linux-2.6.11/drivers/block/noop-iosched.c	2005-03-28 16:43:57.000000000 -0800
@@ -74,6 +74,21 @@ static struct request *elevator_noop_nex
 	return NULL;
 }

+static void elevator_fifo_add_request(request_queue_t *q, struct request *rq,
+				      int where)
+{
+	list_add_tail(&rq->queuelist, &q->queue_head);
+}
+
+static struct elevator_type elevator_fifo = {
+	.ops = {
+		.elevator_next_req_fn		= elevator_noop_next_request,
+		.elevator_add_req_fn		= elevator_fifo_add_request,
+	},
+	.elevator_name = "fifo",
+	.elevator_owner = THIS_MODULE,
+};
+
 static struct elevator_type elevator_noop = {
 	.ops = {
 		.elevator_merge_fn		= elevator_noop_merge,
@@ -87,12 +102,14 @@ static struct elevator_type elevator_noo

 static int __init noop_init(void)
 {
-	return elv_register(&elevator_noop);
+	return (elv_register(&elevator_noop) ||
+		elv_register(&elevator_fifo));
 }

 static void __exit noop_exit(void)
 {
 	elv_unregister(&elevator_noop);
+	elv_unregister(&elevator_fifo);
 }

 module_init(noop_init);



             reply	other threads:[~2005-03-29  1:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-29  1:48 Chen, Kenneth W [this message]
2005-03-29  8:06 ` Jens Axboe
2005-03-29 18:50   ` Chen, Kenneth W
2005-03-29 20:04     ` Jens Axboe
2005-03-29 20:07       ` Chen, Kenneth W
2005-04-05 14:54         ` Jens Axboe
2005-04-06  0:12           ` Chen, Kenneth W
2005-03-29 22:20   ` Bill Davidsen
2005-03-30  7:13     ` Jens Axboe
     [not found] <7A4826DE8867D411BAB8009027AE9EB91DB47626@scsmsx401.amr.corp.intel.com>
2005-04-12 17:58 ` Chen, Kenneth W
2005-04-13  7:45   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503290148.j2T1mOg25279@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®