mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: <axboe@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: [patch] use cheaper elv_queue_empty when unplug a device
Date: Mon, 28 Mar 2005 18:53:49 -0800	[thread overview]
Message-ID: <200503290253.j2T2rqg25691@unix-os.sc.intel.com> (raw)

This patch was posted last year and if I remember correctly, Jens said
he is OK with the patch.  In function __generic_unplug_deivce(), kernel
can use a cheaper function elv_queue_empty() instead of more expensive
elv_next_request to find whether the queue is empty or not. blk_run_queue
can also made conditional on whether queue's emptiness before calling
request_fn().


Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>


--- linux-2.6.11/drivers/block/ll_rw_blk.c.orig	2005-03-28 18:22:26.000000000 -0800
+++ linux-2.6.11/drivers/block/ll_rw_blk.c	2005-03-28 18:44:46.000000000 -0800
@@ -1459,7 +1459,7 @@ void __generic_unplug_device(request_que
 	/*
 	 * was plugged, fire request_fn if queue has stuff to do
 	 */
-	if (elv_next_request(q))
+	if (!elv_queue_empty(q))
 		q->request_fn(q);
 }
 EXPORT_SYMBOL(__generic_unplug_device);
@@ -1589,7 +1589,8 @@ void blk_run_queue(struct request_queue

 	spin_lock_irqsave(q->queue_lock, flags);
 	blk_remove_plug(q);
-	q->request_fn(q);
+	if (!elv_queue_empty(q))
+		q->request_fn(q);
 	spin_unlock_irqrestore(q->queue_lock, flags);
 }
 EXPORT_SYMBOL(blk_run_queue);





             reply	other threads:[~2005-03-29  2:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-29  2:53 Chen, Kenneth W [this message]
2005-03-29  8:06 ` Jens Axboe
2005-03-29  9:19   ` Nick Piggin
2005-03-29  9:21     ` Nick Piggin
2005-03-29  9:28     ` Jens Axboe
2005-03-29  9:50       ` Nick Piggin
2005-03-29 10:06       ` Nick Piggin
2005-03-30  0:57         ` Nick Piggin
2005-03-30  8:11           ` Jens Axboe
2005-04-08  9:45           ` Jens Axboe
2005-04-08  9:55             ` Nick Piggin
2005-04-08 10:02               ` Jens Axboe
2005-04-08 10:22                 ` Nick Piggin
2005-03-29 10:10     ` Arjan van de Ven
2005-03-29 10:19       ` Jens Axboe
2005-03-29 10:23       ` Nick Piggin
2005-03-29 13:15     ` Jens Axboe
2005-03-30  0:07       ` Nick Piggin
2005-03-29 19:02     ` Chen, Kenneth W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503290253.j2T2rqg25691@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®