From: Patrick Gefre <pfg@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: Patrick Gefre <pfg@sgi.com>
Subject: [PATCH 2.6.12 2/2] Altix ioc4 serial - set a better timeout/threshold
Date: Tue, 29 Mar 2005 13:50:02 -0600 (CST) [thread overview]
Message-ID: <20050329195002.30693.4700.sendpatchset@attica.americas.sgi.com> (raw)
In-Reply-To: <20050329194956.30693.94506.sendpatchset@attica.americas.sgi.com>
Set the timeout and threshold to better values.
Signed-off-by: Patrick Gefre <pfg@sgi.com>
Index: linux-2.5-ioc4/drivers/serial/ioc4_serial.c
===================================================================
--- linux-2.5-ioc4.orig/drivers/serial/ioc4_serial.c 2005-03-24 13:56:48.230417236 -0600
+++ linux-2.5-ioc4/drivers/serial/ioc4_serial.c 2005-03-24 13:58:35.560294893 -0600
@@ -1272,8 +1272,9 @@
* and set the rx threshold to that amount. There are 4 chars
* per ring entry, so we'll divide the number of chars that will
* arrive in timeout by 4.
+ * So .... timeout * baud / 10 / HZ / 4, with HZ = 100.
*/
- threshold = timeout * port->ip_baud / 10 / HZ / 4;
+ threshold = timeout * port->ip_baud / 4000;
if (threshold == 0)
threshold = 1; /* otherwise we'll intr all the time! */
@@ -1285,8 +1286,10 @@
writel(port->ip_sscr, &port->ip_serial_regs->sscr);
- /* Now set the rx timeout to the given value */
- timeout = timeout * IOC4_SRTR_HZ / HZ;
+ /* Now set the rx timeout to the given value
+ * again timeout * IOC4_SRTR_HZ / HZ
+ */
+ timeout = timeout * IOC4_SRTR_HZ / 100;
if (timeout > IOC4_SRTR_CNT)
timeout = IOC4_SRTR_CNT;
@@ -1380,7 +1383,7 @@
if (port->ip_tx_lowat == 0)
port->ip_tx_lowat = 1;
- set_rx_timeout(port, port->ip_rx_timeout);
+ set_rx_timeout(port, 2);
return 0;
}
--
prev parent reply other threads:[~2005-03-29 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 19:49 [PATCH 2.6.12 1/2] Altix ioc4 serial - set hfc from ioctl Patrick Gefre
2005-03-29 19:50 ` Patrick Gefre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050329195002.30693.4700.sendpatchset@attica.americas.sgi.com \
--to=pfg@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®