From: Guillaume Foliard <guifo@wanadoo.fr>
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org
Subject: [patch] Fix tg3 driver disable interrupts bug for realtime-preempt-2.6.12-rc1-V0.7.41-14
Date: Tue, 29 Mar 2005 21:16:45 +0200 [thread overview]
Message-ID: <200503292116.45480.guifo@wanadoo.fr> (raw)
Hi,
I just noticed you've accepted a patch from Yang Yi dealing with interrupts
in the e1000 drivers on a PREEMPT_RT kernel. I did not yet understood the
problem but I blindly applied the same fix on the tg3 driver to get rid of the
following message :
network driver disabled interrupts: tg3_start_xmit+0x0/0x620
Signed-off-by: Guillaume Foliard <guifo@wanadoo.fr>
--- linux-2.6.12-rc1/drivers/net/tg3.c 2005-03-18 02:34:13 +0100
+++ linux-2.6.12-rc1-RT-V0.7.41-14/drivers/net/tg3.c 2005-03-29 20:25:33 +0200
@@ -3085,9 +3085,9 @@ static int tg3_start_xmit(struct sk_buff
* So we really do need to disable interrupts when taking
* tx_lock here.
*/
- local_irq_save(flags);
+ local_irq_save_nort(flags);
if (!spin_trylock(&tp->tx_lock)) {
- local_irq_restore(flags);
+ local_irq_restore_nort(flags);
return NETDEV_TX_LOCKED;
}
reply other threads:[~2005-03-29 19:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503292116.45480.guifo@wanadoo.fr \
--to=guifo@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®