From: Neil Horman <nhorman@redhat.com>
To: jamal <hadi@cyberus.ca>
Cc: Neil Horman <nhorman@redhat.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@oss.sgi.com>
Subject: Re: [Patch] net: fix build break when CONFIG_NET_CLS_ACT is not set
Date: Tue, 29 Mar 2005 16:29:49 -0500 [thread overview]
Message-ID: <20050329212949.GR22447@hmsendeavour.rdu.redhat.com> (raw)
In-Reply-To: <1112131560.1079.115.camel@jzny.localdomain>
On Tue, Mar 29, 2005 at 04:26:00PM -0500, jamal wrote:
> On Tue, 2005-03-29 at 16:17, Neil Horman wrote:
>
> > No worries. What exactly is the point of contention on netdev? (I'm not
> > currently following that list). My patch seems to follow the common practice
> > for CONFIG_NET_CLS_ACT, in that all references to the action member of the
> > appropriate struct are themselves ifdef-ed.
>
> We are trying to kill appearance of any #ifdef CONFIG_NET_CLS_ACT in the
> classifiers. The patch you sent is correct except it will introduce
> an ifdef that we are trying to kill. The current workaround is to turn
> on CONFIG_NET_CLS_ACT in the kernel build.
>
> cheers,
> jamal
>
Gotcha. That seems like a pretty good idea. :) Thanks!
Neil
>
>
--
/***************************************************
*Neil Horman
*Software Engineer
*Red Hat, Inc.
*nhorman@redhat.com
*gpg keyid: 1024D / 0x92A74FA1
*http://pgp.mit.edu
***************************************************/
prev parent reply other threads:[~2005-03-29 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 20:25 Neil Horman
2005-03-29 21:12 ` jamal
2005-03-29 21:17 ` Neil Horman
2005-03-29 21:26 ` jamal
2005-03-29 21:29 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050329212949.GR22447@hmsendeavour.rdu.redhat.com \
--to=nhorman@redhat.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®