Re: sata_sil Mod15Write quirk workaround patch for vanilla kernel avaialble.

[John Lash <jkl@sarvega.com>]

On Fri, 01 Apr 2005 00:01:23 +0900
Tejun Heo <htejun@gmail.com> wrote:

> 
>  Hello, guys.
> 
>  I  generated m16w workaround patch for 2.6.11.6 (by just removing two
> lines :-) and set up a page regarding m15w quirk and the workaournd.
> I'm planning on updating m15w patch against the vanilla tree until it
> gets into the mainline so that impatient users can try out and it gets
> more testing.
> 
>  http://home-tj.org/m15w
> 
>  Thanks.
> 
> -- 
> tejun
> 

Tejun,

I applied the patch to a clean 2.6.11.6 kernel and got an unresolved
symbol error for "ATA_TFLAG_LBA". I tried changing that to "ATA_TFLAG_LBA48" and
it compiles and runs.

So far, no problems. Thanks a lot for the patch.

--john

diff -ru format
-----

linux-2.6.11.6-sata_sil/drivers/scsi/sata_sil.c ---
linux-2.6.11.6/drivers/scsi/sata_sil.c      2005-03-31 10:58:59.000000000 -0600
+++ linux-2.6.11.6-sata_sil/drivers/scsi/sata_sil.c     2005-03-31
11:05:00.000000000 -0600 @@ -280,7 +280,7 @@ {
        u64 block = 0;
 
-       BUG_ON(!(tf->flags & ATA_TFLAG_LBA));
+       BUG_ON(!(tf->flags & ATA_TFLAG_LBA48));
 
        block |= (u64)tf->lbal;
        block |= (u64)tf->lbam << 8;
@@ -299,7 +299,7 @@
 static inline void sil_m15w_rewrite_tf (struct ata_taskfile *tf,
                                        u64 block, u16 nsect)
 {
-       BUG_ON(!(tf->flags & ATA_TFLAG_LBA));
+       BUG_ON(!(tf->flags & ATA_TFLAG_LBA48));
 
        tf->nsect = nsect & 0xff;
        tf->lbal = block & 0xff;