From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: mingo@elte.hu, nickpiggin@yahoo.com.au
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [Patch] sched: remove unnecessary sched domains
Date: Fri, 1 Apr 2005 16:20:40 -0800 [thread overview]
Message-ID: <20050401162039.A4320@unix-os.sc.intel.com> (raw)
Appended patch removes the unnecessary scheduler domains(containing
only one sched group) setup during the sched-domain init.
For example on x86_64, we always have NUMA configured in. On Intel EM64T
systems, top most sched domain will be of NUMA and with only one sched_group in
it.
With fork/exec balances(recent Nick's fixes in -mm tree), we always endup
taking wrong decisions because of this topmost domain (as it contains only
one group and find_idlest_group always returns NULL). We will endup loading
HT package completely first, letting active load balance kickin and correct it.
In general, this patch also makes sense with out recent Nick's fixes
in -mm.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
--- linux-2.6.12-rc1-mm4/kernel/sched.c 2005-04-01 10:07:24.183605296 -0800
+++ linux/kernel/sched.c 2005-04-01 15:29:28.274896888 -0800
@@ -4748,6 +4748,21 @@
unsigned long flags;
runqueue_t *rq = cpu_rq(cpu);
int local = 1;
+ struct sched_domain *tmp = sd, *tmp1;
+
+ /* Remove the sched domains which has only one group
+ */
+ while (tmp) {
+ tmp1 = tmp->parent;
+ if (!tmp1)
+ break;
+ if (tmp1->groups == tmp1->groups->next)
+ tmp->parent = tmp1->parent;
+ tmp = tmp->parent;
+ }
+
+ if (sd->parent && sd->groups && sd->groups == sd->groups->next)
+ sd = sd->parent;
sched_domain_debug(sd, cpu);
next reply other threads:[~2005-04-02 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-02 0:20 Siddha, Suresh B [this message]
2005-04-02 2:07 ` Nick Piggin
2005-04-02 3:31 ` Siddha, Suresh B
2005-04-02 3:59 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050401162039.A4320@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®