mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Jackson <pj@engr.sgi.com>
To: blosure@sgi.com, mochel@digitalimplant.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: new SGI TIOCX driver in *-mm driver model locking broken
Date: Sat, 2 Apr 2005 03:43:13 -0800	[thread overview]
Message-ID: <20050402034313.4aa994f5.pj@engr.sgi.com> (raw)

Looks like the new SGI TIOCX driver that Bruce Losure added to *-mm via
the patch "bk-ia64.patch" includes an instance of the old style driver
locking, that Patrick Mochel was changed to a new locking model.

If I try to compile 2.6.12-rc1-mm4 for SN2 with the config option

  CONFIG_SGI_TIOCX=y

the build fails with a bunch of errors on line 527 of tiocx.c, starting
with:

arch/ia64/sn/kernel/tiocx.c: In function `tiocx_exit':
arch/ia64/sn/kernel/tiocx.c:527: error: structure has no member named `bus_list'

The code in question includes the lines:

> static void __exit tiocx_exit(void)
> {
>         struct device *dev;
>         struct device *tdev;
> 
>         ...
>         list_for_each_entry_safe(dev, tdev, &tiocx_bus_type.devices.list,
>                                  bus_list) {

Someone, perhaps Patrick, needs to work the new locking model magic
on this piece of code.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@engr.sgi.com> 1.650.933.1373, 1.925.600.0401

             reply	other threads:[~2005-04-02 11:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-02 11:43 Paul Jackson [this message]
2005-04-02 11:51 ` Andrew Morton
2005-04-02 12:14   ` Paul Jackson
2005-04-02 15:18     ` Bruce Losure
2005-04-02 12:10 ` Paul Jackson
2005-04-02 14:15   ` Bruce Losure

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050402034313.4aa994f5.pj@engr.sgi.com \
    --to=pj@engr.sgi.com \
    --cc=akpm@osdl.org \
    --cc=blosure@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®