Re: [linux-usb-devel] USB glitches after suspend on ppc

[David Brownell <david-b@pacbell.net>]

On Wednesday 06 April 2005 10:20 am, Colin Leroy wrote:
> On 05 Apr 2005 at 13h04, David Brownell wrote:
> > > 
> > > What kind of work on these is needed so that they get in?
> > 
> > Briefly, given 2.6.12-rc2 plus the patches mentioned above,
> > find out what else is needed.
> > ...
> > How's that sound?
> 
> Nice :)
> 
> Ok, here are the results of my tests with 2.6.12-rc2 and the patches
> you sent me applied:
> 
> - plug USB device, sleep, unplug USB device, resume: no more oops
> - sleep, plug in USB device: no oops, but it wakes the laptop up for a
> few seconds; then, it goes back to sleep. No oops on second resume. I
> can live with that :)

Interesting.  Looks like pci_enable_wake(dev, state, 0) isn't actually
disabling wakeup on your hardware.  (Assuming CONFIG_USB_SUSPEND=n; if
not, then it's odd that the system went back to sleep!)  Do you think
that might be related to those calls manipulating the Apple ASICs being
in the OHCI layer rather than up nearer the generic PCI glue?  (I still
think they don't belong in USB code -- ohci or usbcore -- at all.  If
the platform-specific PCI hooks don't suffice, they need fixing.)

Thanks for the testing update.  I'm glad to know that there seems to
be only one (minor) glitch that's PPC-specific!
 

> - once out of two resumes, resume leaves the ports unpowered; so I still
> need my usb-ehci-power.patch that re-powers ports unconditionnaly.

OK, I just posted the patch cleaning up EHCI port power switching;
that should remove the need for that separate patch.  (As well as
fixing some minor annoyances.)

- Dave