From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262604AbVDGVTQ (ORCPT ); Thu, 7 Apr 2005 17:19:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262606AbVDGVTP (ORCPT ); Thu, 7 Apr 2005 17:19:15 -0400 Received: from mail.kroah.org ([69.55.234.183]:10912 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262604AbVDGVTM (ORCPT ); Thu, 7 Apr 2005 17:19:12 -0400 Date: Thu, 7 Apr 2005 14:18:39 -0700 From: Greg KH To: Ladislav Michl Cc: Jean Delvare , LKML , LM Sensors , James Chapman Subject: Re: [PATCH] i2c: new driver for ds1337 RTC Message-ID: <20050407211839.GA5357@kroah.com> References: <20050407111631.GA21190@orphique> <20050407142804.GA11284@orphique> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050407142804.GA11284@orphique> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 07, 2005 at 04:28:04PM +0200, Ladislav Michl wrote: > Here is yet another patch this time fixes only. > CHANGELOG: > * use i2_tranfer function instead of adapter->algo->master_xfer, so > we have proper bus locking. > * BCD2BIN and BIN2BCD are proper macros to use here, see linux/bcd.h > * Move NULL argument checking from get/set date functions to > ds1337_command function, so it is only at one place. Note that other > drivers do not this checking at all and I think it is pointess, > because you have to know that you are passing struct rtc_time anyway. > * dev_dbg should probably print info about device driver we are > debugging so client->dev looks as better choice than > client->adapter->dev. Jean's point is that you should send an individual patch for each type of individual change. It's ok to say "patch 3 requires you to have applied patches 1 and 2" and so on. Please split this up better. thanks, greg k-h