From: Andrew Morton <akpm@osdl.org>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: hifumi.hisashi@lab.ntt.co.jp, marcelo.tosatti@cyclades.com,
neilb@cse.unsw.edu.au, vherva@viasys.com,
linux-kernel@vger.kernel.org, sct@redhat.com
Subject: Re: Linux 2.4.30-rc3 md/ext3 problems (ext3 gurus : please check)
Date: Mon, 11 Apr 2005 13:46:51 -0700 [thread overview]
Message-ID: <20050411134651.719e3434.akpm@osdl.org> (raw)
In-Reply-To: <1113224149.2164.78.camel@sisko.sctweedie.blueyonder.co.uk>
"Stephen C. Tweedie" <sct@redhat.com> wrote:
>
> Andrew, what was the exact illegal state of the pages you were seeing
> when fixing that recent leak? It looks like it's nothing more complex
> than dirty buffers on an anon page.
Correct.
> I think that simply calling
> try_to_release_page() for all the remaining buffers at umount time will
Presumably these pages have no ->mapping, so try_to_release_page() will
call try_to_free_buffers().
> be enough to catch these; if that function fails, it tells us that the
> VM can't reclaim these pages.
Yes, if the buffers are dirty then 2.4's try_to_free_buffers() won't free
them.
> The only thing that would be required on
> top of that would be a check that the page is also on the VM LRU lists.
Why do we have dirty buffers left over at umount time?
next prev parent reply other threads:[~2005-04-11 20:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-26 16:28 Linux 2.4.30-rc3 Marcelo Tosatti
2005-03-28 7:34 ` Ville Herva
2005-03-28 16:55 ` Linux 2.4.30-rc3 md/ext3 problems Ville Herva
2005-03-28 17:25 ` Willy Tarreau
2005-03-28 19:29 ` Ville Herva
2005-03-29 0:10 ` Neil Brown
2005-03-29 21:52 ` Marcelo Tosatti
2005-03-30 4:06 ` Linux 2.4.30-rc3 md/ext3 problems (ext3 gurus : please check) Neil Brown
2005-03-30 11:59 ` Marcelo Tosatti
2005-04-05 22:40 ` Stephen C. Tweedie
[not found] ` <1112740856.4148.145.camel@sisko.sctweedie.blueyonder.co.uk >
2005-04-06 10:01 ` Hifumi Hisashi
2005-04-06 14:20 ` Stephen C. Tweedie
2005-04-07 3:00 ` Hifumi Hisashi
2005-04-06 20:10 ` Stephen C. Tweedie
2005-04-07 15:51 ` Stephen C. Tweedie
2005-04-11 12:55 ` Stephen C. Tweedie
2005-04-11 20:46 ` Andrew Morton [this message]
2005-04-11 22:24 ` Stephen C. Tweedie
2005-04-13 14:34 ` Stephen C. Tweedie
2005-04-27 22:22 ` Stephen C. Tweedie
2005-04-28 8:54 ` Hifumi Hisashi
2005-04-28 11:15 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050411134651.719e3434.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hifumi.hisashi@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=neilb@cse.unsw.edu.au \
--cc=sct@redhat.com \
--cc=vherva@viasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®