From: akpm@osdl.org
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, halr@voltaire.com,
roland@topspin.com
Subject: [patch 162/198] IB: Remove incorrect comments
Date: Tue, 12 Apr 2005 03:33:05 -0700 [thread overview]
Message-ID: <200504121033.j3CAXCgm005809@shell0.pdx.osdl.net> (raw)
From: Hal Rosenstock <halr@voltaire.com>
Eliminate unneeded and misleading comments
Signed-off-by: Hal Rosenstock <halr@voltaire.com>
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/drivers/infiniband/core/agent.c | 2 --
25-akpm/drivers/infiniband/core/mad.c | 1 -
2 files changed, 3 deletions(-)
diff -puN drivers/infiniband/core/agent.c~ib-remove-incorrect-comments drivers/infiniband/core/agent.c
--- 25/drivers/infiniband/core/agent.c~ib-remove-incorrect-comments 2005-04-12 03:21:42.166726584 -0700
+++ 25-akpm/drivers/infiniband/core/agent.c 2005-04-12 03:21:42.171725824 -0700
@@ -129,7 +129,6 @@ static int agent_mad_send(struct ib_mad_
goto out;
agent_send_wr->mad = mad_priv;
- /* PCI mapping */
gather_list.addr = dma_map_single(mad_agent->device->dma_device,
&mad_priv->mad,
sizeof(mad_priv->mad),
@@ -261,7 +260,6 @@ static void agent_send_handler(struct ib
list_del(&agent_send_wr->send_list);
spin_unlock_irqrestore(&port_priv->send_list_lock, flags);
- /* Unmap PCI */
dma_unmap_single(mad_agent->device->dma_device,
pci_unmap_addr(agent_send_wr, mapping),
sizeof(agent_send_wr->mad->mad),
diff -puN drivers/infiniband/core/mad.c~ib-remove-incorrect-comments drivers/infiniband/core/mad.c
--- 25/drivers/infiniband/core/mad.c~ib-remove-incorrect-comments 2005-04-12 03:21:42.168726280 -0700
+++ 25-akpm/drivers/infiniband/core/mad.c 2005-04-12 03:21:42.173725520 -0700
@@ -2283,7 +2283,6 @@ static void cleanup_recv_queue(struct ib
/* Remove from posted receive MAD list */
list_del(&mad_list->list);
- /* Undo PCI mapping */
dma_unmap_single(qp_info->port_priv->device->dma_device,
pci_unmap_addr(&recv->header, mapping),
sizeof(struct ib_mad_private) -
_
reply other threads:[~2005-04-12 10:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504121033.j3CAXCgm005809@shell0.pdx.osdl.net \
--to=akpm@osdl.org \
--cc=halr@voltaire.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®