mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix floppy disk dependencies
Date: Tue, 12 Apr 2005 17:50:34 +0100	[thread overview]
Message-ID: <20050412165034.GN8859@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <E1DL7Bg-0003C9-Vj@raistlin.arm.linux.org.uk>

On Mon, Apr 11, 2005 at 11:15:20PM +0100, Russell King wrote:
> Both the RiscPC and (optionally) EBSA285 have floppy disk
> support.  Allow this option to be selected on these ARM
> platforms again.

I think it's a wrong approach.  Instead of this collection of
dependencies we should bite the bullet and put

config HAS_GENERIC_FDC
	bool
	default y

in arch/*/Kconfig of platforms that do have it and

config BLK_DEV_FD
	tristate "Normal floppy disk support"
        depends on HAS_GENERIC_FDC

in drivers/block/Kconfig.  That way we can express such dependencies
sanely without bringing all the gory details in one pile.

I'll do that unless there are serious objections...

      reply	other threads:[~2005-04-12 16:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-11 22:15 Russell King
2005-04-12 16:50 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050412165034.GN8859@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®