From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: "Kilau, Scott" <Scott_Kilau@digi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ihalainen Nickolay <ihanic@dev.ehouse.ru>,
admin@list.net.ru, linux-kernel@vger.kernel.org,
Wen Xiong <wendyx@us.ibm.com>
Subject: Re: Digi Neo 8: linux-2.6.12_r2 jsm driver
Date: Tue, 12 Apr 2005 20:48:59 +0200 [thread overview]
Message-ID: <20050412184859.GM4965@lug-owl.de> (raw)
In-Reply-To: <335DD0B75189FB428E5C32680089FB9F12215A@mtk-sms-mail01.digi.com>
[-- Attachment #1: Type: text/plain, Size: 2190 bytes --]
On Tue, 2005-04-12 11:42:31 -0500, Kilau, Scott <Scott_Kilau@digi.com>
wrote in message <335DD0B75189FB428E5C32680089FB9F12215A@mtk-sms-mail01.digi.com>:
> The JSM driver was forced to be stripped down when being submitted
> to the kernel sources, and many extended features removed as so to be
> included into the kernel, as the extended features added special ioctls
> and special /proc (/sys for 2.6) files.
There's a consensus that if there's *any* choice, new /proc files as
well as new ioctls shall not be introduced. So if there's management
needed (disclaimer: I don't own such a card), then this interface needs
to be introduced as a generic interface, which might be used by any
further drivers. We've just had this situation for some RAID cards,
where the vendor wanted to introduce a (specific for his devices)
interface. Either do it correct (as of best current practice), or don't
do it at all.
> > I didn't think that you would remove them. I read the posts and
> > wondered *why* they wanted the management pieces removed.
> > One reason to use the Digi products is for the sole fact that
> > they *can* be diagnosed.
> > I'm glad that Digi is still focused properly.
> > I agree that committing the drivers to the main kernel
> > is not the way to go if you are forced to remove dpa and ditty.
Well, again, if this features can only used by your hardware (and
there's proof that no other vendor will add these features *ever*), then
an own interface is okay. But if there's a possibility that a different
vendor *might* introduce these as well, then a generic interface needs
to be build (with first of all only one user: your driver).
> I will let the chips fall where they will, and clean up the mess that
> will soon be introduced into my driver world. =)
That's a plan. Good to head :-)
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-04-12 23:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 16:42 Kilau, Scott
2005-04-12 18:48 ` Jan-Benedict Glaw [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-04-13 14:25 Kilau, Scott
[not found] <3SAEx-7Yo-9@gated-at.bofh.it>
2005-04-12 23:21 ` Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>
2005-04-13 7:27 ` Christoph Hellwig
2005-04-12 21:46 Kilau, Scott
2005-04-12 22:28 ` Matt Mackall
2005-04-12 20:21 Kilau, Scott
2005-04-12 21:32 ` Matt Mackall
2005-04-12 21:42 ` Greg KH
2005-04-12 20:01 Kilau, Scott
2005-04-12 16:54 Kilau, Scott
2005-04-12 17:30 ` Greg KH
2005-04-12 15:55 Kilau, Scott
2005-04-12 15:30 Kilau, Scott
2005-04-12 15:32 ` Christoph Hellwig
2005-04-13 3:27 ` Ricky Beam
2005-04-13 7:26 ` Christoph Hellwig
2005-04-12 16:16 ` Greg KH
2005-04-12 16:23 ` Jan-Benedict Glaw
2005-04-12 14:55 Kilau, Scott
2005-04-12 15:13 ` Christoph Hellwig
2005-04-12 14:02 Kilau, Scott
2005-04-12 14:44 ` Christoph Hellwig
2005-04-12 12:13 Ihalainen Nickolay
2005-04-12 14:44 ` Christoph Hellwig
2005-04-12 15:38 ` Ihalainen Nickolay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050412184859.GM4965@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=Scott_Kilau@digi.com \
--cc=admin@list.net.ru \
--cc=hch@infradead.org \
--cc=ihanic@dev.ehouse.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®