From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/net/pcmcia/nmclan_cs.c: fix a check after use
Date: Wed, 13 Apr 2005 03:53:00 +0100 [thread overview]
Message-ID: <20050413025300.GR8859@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050413021734.GQ3631@stusta.de>
On Wed, Apr 13, 2005 at 04:17:34AM +0200, Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.
Again, check is a pure BS. Argument passed to this sucker comes from
->Instance of the same struct that had ->Handler equal to mace_interrupt().
That would be
link->irq.Handler = &mace_interrupt;
link->irq.Instance = dev;
in nmclan_attach(). Nothing ever modifies that beast afterwards and dev
sure as hell can't be NULL in nmclan_attach() (explict check and a bunch
of dereferencings prior to that point).
Adrian, could you please _read_ the code you are modifying?
next prev parent reply other threads:[~2005-04-13 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-13 2:17 Adrian Bunk
2005-04-13 2:53 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-27 20:44 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050413025300.GR8859@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®