From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
bfennema@falcon.csc.calpoly.edu, linux_udf@hpesjro.fc.hp.com,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/udf/inode.c: fix a check after use
Date: Wed, 13 Apr 2005 04:00:02 +0100 [thread overview]
Message-ID: <20050413030002.GS8859@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050413021737.GR3631@stusta.de>
On Wed, Apr 13, 2005 at 04:17:37AM +0200, Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.
Bullshit. *Please*, read the surrounding code. Again, we never get
to calling that function if we would pass NULL in its first argument.
It's BUG_ON(), not printk(). And oops on entering the function in
question is just as good as BUG_ON(). Remove check and be done with
that.
next prev parent reply other threads:[~2005-04-13 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-13 2:17 Adrian Bunk
2005-04-13 3:00 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-27 20:46 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050413030002.GS8859@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=bfennema@falcon.csc.calpoly.edu \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_udf@hpesjro.fc.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome