mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: juerg@paldo.org, len.brown@intel.com,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix reloading GDT on ACPI S3 wakeup (fwd)
Date: Thu, 14 Apr 2005 22:35:57 +0200	[thread overview]
Message-ID: <20050414203557.GE2801@elf.ucw.cz> (raw)
In-Reply-To: <20050414192240.GB2728@openzaurus.ucw.cz>

Hi!

> This patch - based on
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110055503031009&w=2 -
> makes ACPI S3 wakeup work for me on a ThinkPad T40p laptop with a SMP
> kernel. Without it only UP kernels work. I've been using the patch for
> three months now without any issues.
> 
> The ACPI resume code currently uses a real-mode 16-bit lgdt instruction
> to reload the GDT.  This only restores the lower 24 bits of the GDT base
> address.  In recent SMP kernels, the GDT seems to have moved out of the
> lower 16 megs, thereby causing the ACPI resume to fail -- an invalid GDT
> was being loaded.
> 

Actually x86-64 needs this, too. Any testers?
									Pavel

--- clean/arch/x86_64/kernel/acpi/wakeup.S	2005-01-22 21:24:51.000000000 +0100
+++ linux/arch/x86_64/kernel/acpi/wakeup.S	2005-04-14 22:34:18.000000000 +0200
@@ -67,7 +67,7 @@
 	shll	$4, %eax
 	addl	$(gdta - wakeup_code), %eax
 	movl	%eax, gdt_48a +2 - wakeup_code
-	lgdt	%ds:gdt_48a - wakeup_code		# load gdt with whatever is
+	lgdtl	%ds:gdt_48a - wakeup_code	# load gdt with whatever is
 						# appropriate
 
 	movl	$1, %eax			# protected mode (PE) bit


-- 
Boycott Kodak -- for their patent abuse against Java.

           reply	other threads:[~2005-04-14 20:36 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20050414192240.GB2728@openzaurus.ucw.cz>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050414203557.GE2801@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=juerg@paldo.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®