From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261709AbVDOBbE (ORCPT ); Thu, 14 Apr 2005 21:31:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261711AbVDOBbD (ORCPT ); Thu, 14 Apr 2005 21:31:03 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:58602 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S261710AbVDOBbA (ORCPT ); Thu, 14 Apr 2005 21:31:00 -0400 Date: Fri, 15 Apr 2005 02:31:00 +0100 From: Matthew Wilcox To: Jesper Juhl Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero Message-ID: <20050415013100.GY8669@parcelfarce.linux.theplanet.co.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote: > 'arg' is unsigned so it can never be less than zero, so testing for that > is pointless and also generates a warning when building with gcc -W. This > patch eliminates the pointless check. Didn't Linus already reject this one 6 months ago? -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain