mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Ted Kremenek <kremenek@cs.stanford.edu>
Cc: linux-kernel@vger.kernel.org, Bryan Fulton <bryan@coverity.com>,
	mc@cs.stanford.edu
Subject: Re: [CHECKER] possible missing capability check in ioctl function, drivers/net/cris/eth_v10.c, kernel 2.6.11
Date: Fri, 15 Apr 2005 09:01:04 -0700	[thread overview]
Message-ID: <20050415160104.GB23013@shell0.pdx.osdl.net> (raw)
In-Reply-To: <b86e6e6214dbc3ebe14bf1ec472a1202@cs.stanford.edu>

* Ted Kremenek (kremenek@cs.stanford.edu) wrote:
> In several network drivers that handle the ioctl command SIOCSMIIREG 
> (writes a register on the network card) most implementations check for 
> the CAP_NET_ADMIN capability.  Several drivers use the function 
> "generic_mii_ioctl" to process this command (defined in 
> drivers/net/mii.c).  In mii.c, we see:

This, to me, looks like the device specific (or generic_mii_ioctl)
capability test winds up being redundant.  The top-level checks
capabilities already in net/dev/core.c::dev_ioctl().  So, while there's
some room for cleanup, I don't think this is an acutal bug.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

      parent reply	other threads:[~2005-04-15 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-15  6:27 Ted Kremenek
2005-04-15  7:26 ` Mitchell Blank Jr
2005-04-15 16:01 ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050415160104.GB23013@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=bryan@coverity.com \
    --cc=kremenek@cs.stanford.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mc@cs.stanford.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®