From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, trond.myklebust@fys.uio.no,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
steved@redhat.com, Bryan Henderson <hbryan@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Add 32-bit compatibility for NFSv4 mount
Date: Sun, 17 Apr 2005 03:38:06 +1000 [thread overview]
Message-ID: <20050417033806.65a5786a.sfr@canb.auug.org.au> (raw)
In-Reply-To: <26687.1113576302@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
Hi David,
On Fri, 15 Apr 2005 15:45:02 +0100 David Howells <dhowells@redhat.com> wrote:
>
> @@ -746,10 +747,79 @@ static void *do_smb_super_data_conv(void
> return raw_data;
> }
>
> +struct compat_nfs_string {
> + compat_uint_t len;
> + compat_uptr_t __user data;
^^^^^^
This __user (and the others later) add nothing (I think) as compat_uptr_t is
generally just u32 and compat_ptr() does the right casting.
Otherwise, the patch looks fine for a minimal fix. I agree with David and
Bryan that we need to get the fs specific stuff out of compat.c in the
longer term.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-04-16 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-15 14:45 David Howells
2005-04-16 17:38 ` Stephen Rothwell [this message]
2005-04-26 9:06 ` Using __user with compat_uptr_t David Howells
2005-04-26 14:40 ` Linus Torvalds
2005-04-27 9:28 ` [PATCH] NFS4: Don't use " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050417033806.65a5786a.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=hbryan@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steved@redhat.com \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®