From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
James Morris <jmorris@intercode.com.au>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: resource release functions ought to check for NULL (crypto_free_tfm)
Date: Mon, 18 Apr 2005 21:49:25 +1000 [thread overview]
Message-ID: <20050418114925.GA6854@gondor.apana.org.au> (raw)
In-Reply-To: <Pine.LNX.4.62.0504150106420.3466@dragon.hyggekrogen.localhost>
On Fri, Apr 15, 2005 at 01:15:58AM +0200, Jesper Juhl wrote:
>
> As far as I'm aware there's a general concensus that functions that are
> responsible for freeing resources should be able to cope with being passed
> a NULL pointer. This makes sense as it removes the need for all callers to
In general I'd only do this when most of the callers are doing the
NULL check. As that seems to be the case here, I agree with your
change. I've applied it to my tree.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2005-04-18 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-14 23:15 Jesper Juhl
2005-04-18 11:49 ` Herbert Xu [this message]
2005-04-18 15:23 ` Jesper Juhl
2005-04-19 8:20 ` Herbert Xu
2005-04-19 8:39 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050418114925.GA6854@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=jmorris@intercode.com.au \
--cc=juhl-lkml@dif.dk \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®