mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Olivier Galibert <galibert@pobox.com>
To: "Hack inc." <linux-kernel@vger.kernel.org>
Subject: Can a non-sg scsi write command be more than PAGE_SIZE length?
Date: Tue, 19 Apr 2005 10:47:30 +0200	[thread overview]
Message-ID: <20050419084730.GA96767@dspnet.fr.eu.org> (raw)

...or more importantly, is it allowed.  Kernel is FC3 2.6.10-1.766.

The latest iscsi driver[1] blows on a 32K-long request for a tape write
which followed this path:

 [<f8cef985>] iscsi_queuecommand+0x161/0x2f1 [iscsi_tcp]
 [<f883f724>] scsi_dispatch_cmd+0x1e9/0x24f [scsi_mod]
 [<f88440ff>] scsi_request_fn+0x29a/0x310 [scsi_mod]
 [<c0217487>] blk_insert_request+0x8b/0x9e
 [<f88430b8>] scsi_insert_special_req+0x20/0x26 [scsi_mod]
 [<f8cc043e>] st_do_scsi+0x111/0x147 [st]
 [<f8cc026c>] st_sleep_done+0x0/0xc1 [st]
 [<f8cc189b>] st_write+0x3eb/0x671 [st]
 [<c0152484>] vfs_write+0xb6/0xe2
 [<c015254e>] sys_write+0x3c/0x62
 [<c0103c97>] syscall_call+0x7/0xb

The command is not using scatter-gather (sc->use_sg is 0) but is more
than PAGE_SIZE, and the driver hates that.  So my question is whether
it's allowed (then I'll have to fix the driver, not sure many people
have virtual tapes over iscsi) or whether st_write has to be fixed.

  OG.

[1] 5.0.0.2.

             reply	other threads:[~2005-04-19  8:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-19  8:47 Olivier Galibert [this message]
2005-04-19  8:50 ` Christoph Hellwig
2005-04-19  9:24   ` Olivier Galibert
2005-04-19  9:29     ` Christoph Hellwig
2005-04-19 14:14       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050419084730.GA96767@dspnet.fr.eu.org \
    --to=galibert@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®