From: "David S. Miller" <davem@davemloft.net>
To: Martin Hicks <mort@sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, holt@sgi.com
Subject: Re: [PATCH] pgtables: fix GFP_KERNEL allocation with preempt disabled
Date: Tue, 19 Apr 2005 11:30:44 -0700 [thread overview]
Message-ID: <20050419113044.26911ebf.davem@davemloft.net> (raw)
In-Reply-To: <20050419170413.GB21616@localhost>
On Tue, 19 Apr 2005 13:04:13 -0400
Martin Hicks <mort@sgi.com> wrote:
> This is a fix to the pgtable_quicklist code. There is a GFP_KERNEL
> allocation in pgtable_quicklist_alloc(), which spews the usual warnings
> if the kernel is under heavy VM pressure and the reclaim code is
> invoked.
>
> This patch is against 2.6.12-rc2-mm2
I think you should really drop the preempt disable during this allocation
instead, that's what we do in the sparc64 quicklist code.
It's very simple, change the code to:
preempt_enable();
} else {
preempt_enable();
ret = (unsigned long *) ...;
}
/* preempt_enable() no longer here */
next prev parent reply other threads:[~2005-04-19 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 17:04 Martin Hicks
2005-04-19 18:30 ` David S. Miller [this message]
2005-04-19 18:47 ` Martin Hicks
2005-04-19 18:52 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419113044.26911ebf.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mort@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome