From: Jody McIntyre <scjody@steamballoon.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: bcollins@debian.org, linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's
Date: Tue, 19 Apr 2005 15:13:28 -0400 [thread overview]
Message-ID: <20050419191328.GJ1111@conscoop.ottawa.on.ca> (raw)
In-Reply-To: <20050417195706.GD3625@stusta.de>
On Sun, Apr 17, 2005 at 09:57:07PM +0200, Adrian Bunk wrote:
> This patch removes unneeded EXPORT_SYMBOL's.
Didn't you already send something like this (with fewer removals, mind
you) in December?
http://marc.theaimsgroup.com/?l=linux1394-devel&m=110350765817261&w=2
Given the objections to your December patch, why should we accept this
one now?
Jody
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> drivers/ieee1394/ieee1394_core.c | 16 ----------------
> 1 files changed, 16 deletions(-)
>
> --- linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_core.c.old 2005-04-17 20:49:31.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_core.c 2005-04-17 20:57:34.000000000 +0200
> @@ -1225,9 +1225,7 @@
> EXPORT_SYMBOL(hpsb_set_packet_complete_task);
> EXPORT_SYMBOL(hpsb_alloc_packet);
> EXPORT_SYMBOL(hpsb_free_packet);
> -EXPORT_SYMBOL(hpsb_send_phy_config);
> EXPORT_SYMBOL(hpsb_send_packet);
> -EXPORT_SYMBOL(hpsb_send_packet_and_wait);
> EXPORT_SYMBOL(hpsb_reset_bus);
> EXPORT_SYMBOL(hpsb_bus_reset);
> EXPORT_SYMBOL(hpsb_selfid_received);
> @@ -1246,9 +1244,6 @@
> EXPORT_SYMBOL(hpsb_make_lock64packet);
> EXPORT_SYMBOL(hpsb_make_phypacket);
> EXPORT_SYMBOL(hpsb_make_isopacket);
> -EXPORT_SYMBOL(hpsb_read);
> -EXPORT_SYMBOL(hpsb_write);
> -EXPORT_SYMBOL(hpsb_lock);
> EXPORT_SYMBOL(hpsb_packet_success);
>
> /** highlevel.c **/
> @@ -1265,8 +1260,6 @@
> EXPORT_SYMBOL(hpsb_set_hostinfo_key);
> EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
> EXPORT_SYMBOL(hpsb_set_hostinfo);
> -EXPORT_SYMBOL(highlevel_add_host);
> -EXPORT_SYMBOL(highlevel_remove_host);
> EXPORT_SYMBOL(highlevel_host_reset);
>
> /** nodemgr.c **/
> @@ -1275,7 +1268,6 @@
> EXPORT_SYMBOL(hpsb_register_protocol);
> EXPORT_SYMBOL(hpsb_unregister_protocol);
> EXPORT_SYMBOL(ieee1394_bus_type);
> -EXPORT_SYMBOL(nodemgr_for_each_host);
>
> /** csr.c **/
> EXPORT_SYMBOL(hpsb_update_config_rom);
> @@ -1312,19 +1304,11 @@
> EXPORT_SYMBOL(hpsb_iso_recv_flush);
>
> /** csr1212.c **/
> -EXPORT_SYMBOL(csr1212_create_csr);
> -EXPORT_SYMBOL(csr1212_init_local_csr);
> -EXPORT_SYMBOL(csr1212_new_immediate);
> EXPORT_SYMBOL(csr1212_new_directory);
> -EXPORT_SYMBOL(csr1212_associate_keyval);
> EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
> -EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
> EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
> EXPORT_SYMBOL(csr1212_release_keyval);
> -EXPORT_SYMBOL(csr1212_destroy_csr);
> EXPORT_SYMBOL(csr1212_read);
> -EXPORT_SYMBOL(csr1212_generate_csr_image);
> EXPORT_SYMBOL(csr1212_parse_keyval);
> -EXPORT_SYMBOL(csr1212_parse_csr);
> EXPORT_SYMBOL(_csr1212_read_keyval);
> EXPORT_SYMBOL(_csr1212_destroy_keyval);
>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> mailing list linux1394-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux1394-devel
--
next prev parent reply other threads:[~2005-04-19 19:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-17 19:57 Adrian Bunk
2005-04-19 19:13 ` Jody McIntyre [this message]
2005-04-19 19:43 ` Arjan van de Ven
2005-04-19 22:00 ` Stefan Richter
2005-04-20 7:26 ` Arjan van de Ven
2005-04-20 16:31 ` Stefan Richter
2005-04-20 16:35 ` Arjan van de Ven
2005-04-20 17:09 ` Stefan Richter
2005-04-20 19:19 ` Arjan van de Ven
2005-04-20 20:32 ` Dan Dennedy
2005-04-20 20:49 ` Adrian Bunk
2005-04-20 23:43 ` Stefan Richter
2005-04-27 21:11 ` Stefan Richter
2005-04-27 21:38 ` Jesper Juhl
2005-04-27 21:44 ` Adrian Bunk
2005-05-12 22:29 ` Adrian Bunk
2005-05-12 22:30 ` Adrian Bunk
2005-05-12 23:24 ` Stefan Richter
2005-05-13 14:00 ` [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419191328.GJ1111@conscoop.ottawa.on.ca \
--to=scjody@steamballoon.com \
--cc=bcollins@debian.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®