From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ppc64: rename arch/ppc64/kernel/pSeries_pci.c
Date: Wed, 20 Apr 2005 04:12:45 +0200 [thread overview]
Message-ID: <20050420021245.GA7257@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <200504200152.58965.arnd@arndb.de>
On Wed, 20 April 2005 01:52:56 +0200, Arnd Bergmann wrote:
>
> - if (buid) {
> - ret = rtas_call(ibm_read_pci_config, 4, 2, &returnval,
> - addr, buid >> 32, buid & 0xffffffff, size);
> - } else {
> - ret = rtas_call(read_pci_config, 2, 2, &returnval, addr, size);
> - }
> - *val = returnval;
> -
> - if (ret)
> - return PCIBIOS_DEVICE_NOT_FOUND;
You might want to be consistent wrt. braces for one-line conditional
statements.
Jörn
--
Optimizations always bust things, because all optimizations are, in
the long haul, a form of cheating, and cheaters eventually get caught.
-- Larry Wall
next prev parent reply other threads:[~2005-04-20 2:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 23:49 [PATCH 0/4] ppc64: prepare for integration of BPA platform Arnd Bergmann
2005-04-19 23:52 ` [PATCH 1/4] ppc64: rename arch/ppc64/kernel/pSeries_pci.c Arnd Bergmann
2005-04-20 2:12 ` Jörn Engel [this message]
2005-04-20 2:27 ` Paul Jackson
2005-05-06 5:10 ` Paul Mackerras
2005-05-07 11:31 ` Arnd Bergmann
2005-04-20 0:15 ` [PATCH 2/4] ppc64: Split out pSeries specific code from rtas_pci.c Arnd Bergmann
2005-04-20 0:22 ` [PATCH 3/4] ppc64: add a simple nvram lowlevel driver Arnd Bergmann
2005-04-20 0:29 ` [PATCH 4/4] ppc64: add an rtas based watchdog driver Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050420021245.GA7257@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome