From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261171AbVDUBe3 (ORCPT ); Wed, 20 Apr 2005 21:34:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261167AbVDUBe3 (ORCPT ); Wed, 20 Apr 2005 21:34:29 -0400 Received: from colino.net ([213.41.131.56]:6132 "EHLO paperstreet.colino.net") by vger.kernel.org with ESMTP id S261171AbVDUBeZ (ORCPT ); Wed, 20 Apr 2005 21:34:25 -0400 Date: Thu, 21 Apr 2005 03:34:19 +0200 From: Colin Leroy To: Roman Zippel Cc: "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH] hfsplus: add an option to force r/w mount Message-ID: <20050421033419.24e5c417@jack.colino.net> In-Reply-To: References: <20050420220242.48cb1427@jack.colino.net> X-Mailer: Sylpheed-Claws 1.9.6cvs36 (GTK+ 2.6.4; powerpc-unknown-linux-gnu) X-Face: Fy:*XpRna1/tz}cJ@O'0^:qYs:8b[Rg`*8,+o^[fI?<%5LeB,Xz8ZJK[r7V0hBs8G)*&C+XA0qHoR=LoTohe@7X5K$A-@cN6n~~J/]+{[)E4h'lK$13WQf$.R+Pi;E09tk&{t|;~dakRD%CLHrk6m!?gA,5|Sb=fJ=>[9#n1Bu8?VngkVM4{'^'V_qgdA.8yn3) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 20 Apr 2005 at 22h04, Roman Zippel wrote: Hi, > Hi, > > On Wed, 20 Apr 2005, Colin Leroy wrote: > > > for some reason yet unknown, fsck.hfsplus doesn't correctly set the > > HFSPLUS_VOL_UNMNT flag here. > > If fsck doesn't mark it clean, there must be a reason and that also > means you shouldn't mount it writable. that's what i thought too, but adding debug printf() to it, i see that it marks it clean at the end. However that doesn't seem to effectively land on the disc. imho the patch has an interest anyway... -- Colin