From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Roland Dreier <roland@topspin.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix include order in mthca_memfree.c
Date: Mon, 25 Apr 2005 05:04:42 +0100 [thread overview]
Message-ID: <20050425040442.GO13052@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <52vf6bwps9.fsf@topspin.com>
On Sun, Apr 24, 2005 at 07:31:18PM -0700, Roland Dreier wrote:
> - Out of curiousity, what arch and/or config requires <linux/mm.h>?
> I regularly cross-compile drivers/infiniband for i386, x86_64, ppc64,
> ia64, sparc64 and ppc, and I haven't needed <linux/mm.h> in mthca_memfree.c.
alpha, for instance. You are using lowmem_page_address(). That's
from linux/mm.h and that's an inline function, so missing include
is fatal.
FWIW, the chain of includes that leads to mm.h on i386 is mthca_memfree.h ->
linux/pci.h -> asm-i386/pci.h -> linux/mm.h. Other platforms differ...
> - When making changes to drivers/infiniband, can you please cc the
> maintainers or at least a public mailing list? As far as I can
> tell, the patch went directly to Linus with no public review, which
> doesn't seem appropriate, no matter how trivial the change.
>
> - When adding includes, please match the existing style and put
> <linux/xxx.h> includes before any local "yyy.h" includes.
Sure, no problem.
prev parent reply other threads:[~2005-04-25 4:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 2:31 Roland Dreier
2005-04-25 4:04 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050425040442.GO13052@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®