From: Daniel Phillips <phillips@istop.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: David Teigland <teigland@redhat.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 5/7] dlm: device interface
Date: Mon, 25 Apr 2005 17:27:58 -0400 [thread overview]
Message-ID: <200504251727.58644.phillips@istop.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0504251754330.2941@dragon.hyggekrogen.localhost>
On Monday 25 April 2005 12:09, Jesper Juhl wrote:
> On Mon, 25 Apr 2005, David Teigland wrote:
> > +/* Close on control device */
> > +static int dlm_ctl_close(struct inode *inode, struct file *file)
> > +{
> > + return 0;
> > +}
>
> return void? and what's the purpose of this function? seems silly to me to
> have a function that does nothing but return 0 ever.
How about just adding "inline" calling it "documentation"?
Regards,
Daniel
next prev parent reply other threads:[~2005-04-25 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 15:13 David Teigland
2005-04-25 16:09 ` Jesper Juhl
2005-04-25 21:27 ` Daniel Phillips [this message]
2005-04-25 21:00 ` Arjan van de Ven
2005-04-25 21:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504251727.58644.phillips@istop.com \
--to=phillips@istop.com \
--cc=akpm@osdl.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®