From: Olivier Galibert <galibert@pobox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: avi@argo.co.il, linux-kernel@vger.kernel.org
Subject: Re: tcp_sendpage and page allocation lifetime vs. iscsi
Date: Tue, 26 Apr 2005 00:31:00 +0200 [thread overview]
Message-ID: <20050425223100.GB64842@dspnet.fr.eu.org> (raw)
In-Reply-To: <20050425150840.5f27f77a.davem@davemloft.net>
On Mon, Apr 25, 2005 at 03:08:40PM -0700, David S. Miller wrote:
> You could do something similar in iSCSI and for now I highly
> suggest that is what you do.
Ok, I'll try to implement that.
> In short, you're using an API in a way it was never designed
> to be used.
Heh, I don't, I'm just debugging it ;-)
It's interesting though that both the 4.x guys (linux-iscsi) and the
5.x ones (openiscsi, now both have merged) did the exact same mistake
while afaik their developments were independant. There is a
documentation issue there. If you could put what you just said in
Documentation/*, it should hopefully prevent this kind of
hard-to-track mistakes in the future.
OG.
next prev parent reply other threads:[~2005-04-25 22:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 17:02 Olivier Galibert
2005-04-25 19:11 ` Avi Kivity
2005-04-25 19:19 ` David S. Miller
2005-04-25 19:43 ` Avi Kivity
2005-04-25 19:37 ` David S. Miller
2005-04-25 22:06 ` Olivier Galibert
2005-04-25 22:08 ` David S. Miller
2005-04-25 22:31 ` Olivier Galibert [this message]
2005-04-29 17:09 ` Dmitry Yusupov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050425223100.GB64842@dspnet.fr.eu.org \
--to=galibert@pobox.com \
--cc=avi@argo.co.il \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®