From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: andrea@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [patch] __block_write_full_page bug
Date: Tue, 26 Apr 2005 04:50:39 -0700 [thread overview]
Message-ID: <20050426045039.702d9075.akpm@osdl.org> (raw)
In-Reply-To: <426C6A63.80408@yahoo.com.au>
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> When running
> fsstress -v -d $DIR/tmp -n 1000 -p 1000 -l 2
> on an ext2 filesystem with 1024 byte block size, on SMP i386 with 4096 byte
> page size over loopback to an image file on a tmpfs filesystem, I would
> very quickly hit
> BUG_ON(!buffer_async_write(bh));
> in fs/buffer.c:end_buffer_async_write
>
> It seems that more than one request would be submitted for a given bh
> at a time. __block_write_full_page looks like the culprit - with the
> following patch things are very stable.
What's the bug? I don't see it.
Was an ENOSPC involved?
Those tests for buffer_async_write(bh) are redundant now, aren't they?
next prev parent reply other threads:[~2005-04-26 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 3:56 Nick Piggin
2005-04-26 11:50 ` Andrew Morton [this message]
2005-04-26 12:00 ` Nick Piggin
2005-04-26 12:47 ` Andrew Morton
2005-04-27 0:10 ` Nick Piggin
2005-04-27 1:02 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050426045039.702d9075.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®