From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@muc.de>
Cc: luming.yu@intel.com, linux-kernel@vger.kernel.org, racing.guo@intel.com
Subject: Re: [PATCH]porting lockless mce from x86_64 to i386
Date: Wed, 27 Apr 2005 11:38:00 -0700 [thread overview]
Message-ID: <20050427113800.6be34642.akpm@osdl.org> (raw)
In-Reply-To: <20050427123852.GD12597@muc.de>
Andi Kleen <ak@muc.de> wrote:
>
> On Tue, Apr 26, 2005 at 01:27:30PM +0800, Yu, Luming wrote:
> >
> > Forward a patch :
>
> Some comments:
>
> The asmlinkage on x86-64 is not really needed. You can remove
> the ifdef. fastcall is fine, although it is a nop.
>
> The u64 tsc[NR CPUS] on the stack is a stack overflow with big
> NR_CPUS. I have
> a patch locally here to fix it, but you could just apply it
> anyways when you move the code. Fix is to use kmalloc here.
>
OK, thanks. Luming, could you please reissue the second patch, including
the above fixes as well as the two warning fixes which we discussed?
next prev parent reply other threads:[~2005-04-27 18:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200504261327.30928.luming.yu@intel.com>
2005-04-27 12:38 ` Andi Kleen
2005-04-27 18:38 ` Andrew Morton [this message]
2005-04-29 15:27 ` Andi Kleen
2005-04-29 16:42 Yu, Luming
2005-05-02 1:01 Guo, Racing
2005-05-02 16:10 ` Andi Kleen
2005-05-02 16:15 Pallipadi, Venkatesh
2005-05-02 17:15 ` Andi Kleen
2005-05-02 18:31 ` Andrew Morton
2005-05-02 19:11 ` Andi Kleen
2005-05-02 19:36 ` Andrew Morton
2005-05-05 15:14 ` Adrian Bunk
2005-05-03 16:16 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050427113800.6be34642.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
--cc=racing.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®