mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Jes Sorensen <jes@wildopensource.com>,
	Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: returning non-ram via ->nopage, was Re: [patch] mspec driver for 2.6.12-rc2-mm3
Date: Wed, 27 Apr 2005 16:55:26 +0100	[thread overview]
Message-ID: <20050427155526.GA25921@infradead.org> (raw)
In-Reply-To: <426FB56B.5000006@pobox.com>

On Wed, Apr 27, 2005 at 11:53:15AM -0400, Jeff Garzik wrote:
> I don't see anything wrong with a ->nopage approach.
> 
> At Linus's suggestion, I used ->nopage in the implementation of 
> sound/oss/via82cxxx_audio.c.

The difference is that you return kernel memory (actually pci_alloc_consistant
memory that has it's own set of problems), while this is memory not in mem_map,
so he allocates some regularly kernel memory too to have a struct page and
just leaks it


  reply	other threads:[~2005-04-27 15:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12  9:56 Jes Sorensen
2005-04-12 10:21 ` Andrew Morton
2005-04-12 10:22 ` Andrew Morton
2005-04-12 10:27 ` Andrew Morton
2005-04-12 14:50   ` Jes Sorensen
2005-04-13 20:43     ` Christoph Hellwig
2005-04-22 11:21       ` Jes Sorensen
2005-04-24 10:16         ` Christoph Hellwig
2005-04-25 10:13           ` Jes Sorensen
2005-04-25 14:32             ` Christoph Hellwig
2005-04-25 14:41             ` efi_memmap_walk_uc, was " Christoph Hellwig
2005-04-25 14:47             ` returning non-ram via ->nopage, " Christoph Hellwig
2005-04-26 22:14               ` Jes Sorensen
2005-04-27 15:53                 ` Jeff Garzik
2005-04-27 15:55                   ` Christoph Hellwig [this message]
2005-04-27 18:03                     ` Jes Sorensen
2005-04-27 18:55                       ` Russell King
2005-05-03 20:40                 ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050427155526.GA25921@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=jes@wildopensource.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome