Re: [BUG] 2.6.12-rc3: unkillable java process in TASK_RUNNING on AMD64

["Rafael J. Wysocki" <rjw@sisk.pl>]

Hi,

On Wednesday, 27 of April 2005 15:54, Andi Kleen wrote:
> 
> Does this patch fix the problem?

Yes, it does, apparently (ie I'm unable to reproduce it). :-)

> Initialize workmask correct on interrupt signal handling
> 
> Readd missing clis in the interrupt return path.
> 
> Signed-off-by: Andi Kleen <ak@suse.de>
> 
> 
> 
> diff -u linux-2.6.12rc3/arch/x86_64/kernel/entry.S-o linux-2.6.12rc3/arch/x86_64/kernel/entry.S
> --- linux-2.6.12rc3/arch/x86_64/kernel/entry.S-o	2005-04-22 12:48:11.000000000 +0200
> +++ linux-2.6.12rc3/arch/x86_64/kernel/entry.S	2005-04-27 15:52:49.305183345 +0200
> @@ -296,6 +296,7 @@
>  	call syscall_trace_leave
>  	popq %rdi
>  	andl $~(_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT|_TIF_SINGLESTEP),%edi
> +	cli	
>  	jmp int_restore_rest
>  	
>  int_signal:
> @@ -307,6 +308,7 @@
>  1:	movl $_TIF_NEED_RESCHED,%edi	
>  int_restore_rest:
>  	RESTORE_REST
> +	cli	
>  	jmp int_with_check
>  	CFI_ENDPROC
>  		
> @@ -490,7 +492,8 @@
>  	call do_notify_resume
>  	RESTORE_REST
>  	cli
> -	GET_THREAD_INFO(%rcx)	
> +	GET_THREAD_INFO(%rcx)
> +	movl $_TIF_WORK_MASK,%edi	
>  	jmp retint_check
>  
>  #ifdef CONFIG_PREEMPT

I assume that the Alexander's patch is not needed with this one?

Greets,
Rafael


-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"