From: "Randy.Dunlap" <rddunlap@osdl.org>
To: jermar@itbs.cz
Cc: len.brown@intel.com, torvalds@osdl.org,
aul.s.diefenbaugh@intel.com, jun.nakajima@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: PATCH: acpi_find_rsdp() diverges from ACPI specification
Date: Fri, 29 Apr 2005 14:43:21 -0700 [thread overview]
Message-ID: <20050429144321.3398db9a.rddunlap@osdl.org> (raw)
In-Reply-To: <20050429230350.qid9o7yht3qckkg8@mail.hosting123.cz>
On Fri, 29 Apr 2005 23:03:50 +0200 jermar@itbs.cz wrote:
| Hello,
|
| I found out that acpi_find_rsdp() tries to find the RSDP structure in an area
| bit larger than the ACPI specification wants. The right interval should start
| at 0xe0000 and end at 0xfffff. The search area is thus 128K+1B large.
The search area is thus 128 KB large, so I agree with the intent of
this patch, except for the +1B.
| Given the semantics of acpi_scan_rsdp(), the second argument should therefore be
| the size, not the end address.
Yes.
| Should there be any comments, please email me directly as I don't regularily
| read LKM.
|
| Please, apply.
|
| Jakub
|
| --- linux-2.6.11.7/arch/i386/kernel/acpi/boot.c 2005-04-07 20:58:17.000000000
| +0200
| +++ linux-2.6.11.7-acpi-patch/arch/i386/kernel/acpi/boot.c 2005-04-29
| 21:39:08.000000000 +0200
| @@ -644,7 +644,7 @@ acpi_find_rsdp (void)
| */
| rsdp_phys = acpi_scan_rsdp (0, 0x400);
| if (!rsdp_phys)
| - rsdp_phys = acpi_scan_rsdp (0xE0000, 0xFFFFF);
| + rsdp_phys = acpi_scan_rsdp (0xE0000, 128*1024 + 1);
Just drop the "+ 1".
|
| return rsdp_phys;
| }
---
~Randy
next prev parent reply other threads:[~2005-04-29 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-29 21:03 jermar
2005-04-29 21:43 ` Randy.Dunlap [this message]
2005-05-06 22:21 ` Jakub Jermar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050429144321.3398db9a.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=aul.s.diefenbaugh@intel.com \
--cc=jermar@itbs.cz \
--cc=jun.nakajima@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®