mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Pisa <pisa@cmp.felk.cvut.cz>
To: Russell King <rmk+lkml@arm.linux.org.uk>,
	Sam Ravnborg <sam@ravnborg.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] preserve ARCH and CROSS_COMPILE in the build directory generated Makefile
Date: Sat, 30 Apr 2005 00:32:13 +0200	[thread overview]
Message-ID: <200504300032.13764.pisa@cmp.felk.cvut.cz> (raw)
In-Reply-To: <20050429224212.G30010@flint.arm.linux.org.uk>

On Friday 29 April 2005 23:42, Russell King wrote:
> On Fri, Apr 29, 2005 at 11:00:53PM +0200, Sam Ravnborg wrote:
> > On Fri, Apr 29, 2005 at 01:35:33PM +0200, Pavel Pisa wrote:
> > > This patch ensures, that architecture and target cross-tools prefix
> > > is preserved in the Makefile generated in the build directory for
> > > out of source tree kernel compilation. This prevents accidental
> > > screwing of configuration and builds for the case, that make without
> > > full architecture specific options is invoked in the build
> > > directory. It is secure use accustomed "make", "make xconfig",
> > > etc. without fear and special care now.
> >
> > Hi Pavel.
> > I will not apply this path because it introduce a difference when
> > building usign a separate output direcory compared to an in-tree build.
> >
> > I have briefly looked into a solution where I could add this information
> > in .config but was sidetracked by other stuff so I newer got it working.
> >
> > The build system for the kernel needs to be as predictable as possible
> > and introducing functionality that is only valid when using a separate
> > output directory does not help here.

> Without it, folk will then do (and this is taken from someone elses
> example):

> which I think you'll agree is far worse.

Hello Sam and Russell,

thanks, Russell, for defending me through pointing me
as an bad example :-) .

Excuse me for that outcome of my two neurons scratch,
but I have decided to send my ideas for discussion
and possibly to help others. The decision,
what is good thing to do now and what should
be left in air for future better decisions
is on you. Thanks for energy put into reading
and thinking about my ideas.

I provide another idea, which is not dependant
on out of source tree build

ifeq ("$(origin ARCH)", "command line")
prepare1: archpreserve

archpreserve:
	echo "ARCH ?= $(ARCH)" >$(objtree)/.archconfig
	echo "CROSS_COMPILE ?= $(CROSS_COMPILE)" >>$(objtree)/.archconfig
else
-include $(objtree)/.archconfig
endif

With wish of sunny weekend 

                Pavel

  reply	other threads:[~2005-04-29 22:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-29 11:35 Pavel Pisa
2005-04-29 21:00 ` Sam Ravnborg
2005-04-29 21:42   ` Russell King
2005-04-29 22:32     ` Pavel Pisa [this message]
2005-04-29 22:26   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200504300032.13764.pisa@cmp.felk.cvut.cz \
    --to=pisa@cmp.felk.cvut.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®