From: Adrian Bunk <bunk@stusta.de>
To: Ashok Raj <ashok.raj@intel.com>, Andrew Morton <akpm@osdl.org>
Cc: Zwane Mwaikambo <zwane@holomorphy.com>, Andi Kleen <ak@muc.de>,
linux-kernel@vger.kernel.org
Subject: [-mm patch] kernel/irq/manage.c: remove the empty set_irq_info()
Date: Sun, 1 May 2005 23:00:11 +0200 [thread overview]
Message-ID: <20050501210011.GY3592@stusta.de> (raw)
I do still not like an empty global function.
All other cases are already handled by static inline's, so let's do the
same with this one.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
include/linux/irq.h | 8 +++++++-
kernel/irq/manage.c | 4 ----
2 files changed, 7 insertions(+), 5 deletions(-)
--- linux-2.6.12-rc3-mm2-full/include/linux/irq.h.old 2005-05-01 14:55:16.000000000 +0200
+++ linux-2.6.12-rc3-mm2-full/include/linux/irq.h 2005-05-01 17:56:12.000000000 +0200
@@ -158,10 +158,16 @@
set_native_irq_info(irq, mask);
}
#endif // CONFIG_PCI_MSI
+
#else
+
#define move_irq(x)
#define move_native_irq(x)
-extern void set_irq_info(unsigned int irq, cpumask_t mask);
+
+static inline void set_irq_info(int irq, cpumask_t mask)
+{
+}
+
#endif // CONFIG_GENERIC_PENDING_IRQ
extern int no_irq_affinity;
--- linux-2.6.12-rc3-mm2-full/kernel/irq/manage.c.old 2005-05-01 14:56:11.000000000 +0200
+++ linux-2.6.12-rc3-mm2-full/kernel/irq/manage.c 2005-05-01 14:56:24.000000000 +0200
@@ -40,10 +40,6 @@
EXPORT_SYMBOL(synchronize_irq);
-#else
-void set_irq_info(unsigned int irq, cpumask_t mask)
-{
-}
#endif
/**
next reply other threads:[~2005-05-01 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 21:00 Adrian Bunk [this message]
2005-05-01 23:13 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050501210011.GY3592@stusta.de \
--to=bunk@stusta.de \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®