From: Tom Rini <trini@kernel.crashing.org>
To: David Woodhouse <dwmw2@infradead.org>,
Kumar Gala <kumar.gala@freescale.com>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Phil Oester <kernel@linuxace.com>,
linux-kernel@vger.kernel.org
Subject: Re: Garbage on serial console after serial driver loads
Date: Tue, 3 May 2005 09:16:58 -0700 [thread overview]
Message-ID: <20050503161658.GP1221@smtp.west.cox.net> (raw)
In-Reply-To: <20050503151159.GL1221@smtp.west.cox.net>
On Tue, May 03, 2005 at 08:11:59AM -0700, Tom Rini wrote:
> On Tue, May 03, 2005 at 03:17:12PM +0100, David Woodhouse wrote:
> > On Mon, 2005-03-28 at 20:02 +0100, Russell King wrote:
> > > Is this patch ok for you?
> >
> > Not really; it's just a quick hack applied without any real
> > consideration of the problem. If we're messing up the baud rate when we
> > change the master clock, then just make it change the divisor
> > accordingly at the same time. We don't seem to store the active
> > parameters of the serial console anywhere useful; we can do it just by
> > reading back the divisor and multiplying by eight though...
> >
> > Tom, does this also mean you don't need the 'ifndef ppc'?
>
> I don't recall the problem well enough right now, but I'll go toss this
> into a current git tree and let you know.
Dropping the 'ifndef ppc' is fine on my Motorola Sandpoint which I do
believe exhibited the problem previously. I've cc'd Kumar Gala since I see
on IRC that 85xx boards might also have had a problem here.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-05-03 16:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 17:36 Phil Oester
2005-03-28 19:02 ` Russell King
2005-03-28 23:57 ` Dave Airlie
2005-05-03 14:17 ` David Woodhouse
2005-05-03 15:04 ` Phil Oester
2005-05-03 15:11 ` Tom Rini
2005-05-03 15:23 ` David Woodhouse
2005-05-03 16:00 ` Tom Rini
2005-05-03 16:16 ` Tom Rini [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-27 11:11 Jan Engelhardt
2005-03-25 20:24 Luca
2005-03-25 20:38 ` Russell King
2005-03-25 21:01 ` Luca
2005-03-26 10:16 ` Jan Engelhardt
2005-03-26 14:35 ` Luca
2005-03-26 15:10 ` Russell King
2005-03-26 15:55 ` Phil Oester
2005-03-26 16:37 ` Russell King
2005-03-26 17:19 ` Phil Oester
2005-03-26 17:22 ` Phil Oester
2005-04-13 12:45 ` Paul Slootman
2005-04-18 20:21 ` Phil Oester
2005-04-18 23:14 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050503161658.GP1221@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=dwmw2@infradead.org \
--cc=kernel@linuxace.com \
--cc=kumar.gala@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®