Re: [PATCH] dynamic wep keys for airo.c

[Jean Tourrilhes <jt@hpl.hp.com>]

Benjamin Reed wrote :
> 
> I'm resubmitting a patch for the 2.6.11.8 aironet driver (airo.c) that will 
> enable dynamic wep keying without disabling the MAC. It allows 
> us to use xsupplicant with the driver.
> 
> Aironet provides the ability to set WEP keys permanently or 
> temporarily. There is a special IW_ENCODE_TEMP flag for selecting
> which type of key you are setting. However, apart from iwconfig, 
> nobody seems to use this flag. When a permanent WEP key is set, 
> the MAC must be disabled. I have added a module parameter to skip
> disabling the MAC even if a permanent WEP key is set. Using this 
> flag allows xsupplicant to work without modification.

	Hmm... I don't know why you are so afraid of submitting a
patch to xsupplicant (and wpa_supplicant). Having xsupplicant *always*
setting IW_ENCODE_TEMP would be worthwhile. Have you even try to
submit a patch to the author of xsupplicant ?
	There was other driver having issues with with not reseting
the MAC while changing the WEP key. For example, some Lucent firmware
may lock up if you set WEP without fully reseting the MAC. So, having
IW_ENCODE_TEMP in xsupplicant would mean that the driver could support
802.1x properly if the firmware is sane and remain conservative while
setting static WEP keys, i.e. the best of both words. Driver that are
sane (moder hardware) can just ignore IW_ENCODE_TEMP.
	With respect to airo, I think it would be nice if xsupplicant
did not pollute the WEP EEprom, so that next time you roam to a static
WEP AP, you can resuse the EEprom keys.

	In summary, I believe that a correct solution is not so
difficult to implement (just a 2 line patch for xsupplicant and
wpa_supplicant), therefore I don't beleive we should go with
workarounds.

	Have fun...

	Jean