From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261814AbVEECdj (ORCPT ); Wed, 4 May 2005 22:33:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261835AbVEECdj (ORCPT ); Wed, 4 May 2005 22:33:39 -0400 Received: from lixom.net ([66.141.50.11]:53702 "EHLO mail.lixom.net") by vger.kernel.org with ESMTP id S261814AbVEECde (ORCPT ); Wed, 4 May 2005 22:33:34 -0400 Date: Wed, 4 May 2005 21:31:19 -0500 To: Andy Whitcroft Cc: linuxppc64-dev@ozlabs.org, paulus@samba.org, anton@samba.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, haveblue@us.ibm.com, kravetz@us.ibm.com Subject: Re: [2/3] add memory present for ppc64 Message-ID: <20050505023119.GA20283@austin.ibm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6+20040907i From: Olof Johansson Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 04, 2005 at 09:29:57PM +0100, Andy Whitcroft wrote: > diff -X /home/apw/brief/lib/vdiff.excl -rupN reference/arch/ppc64/Kconfig current/arch/ppc64/Kconfig > --- reference/arch/ppc64/Kconfig 2005-05-04 20:54:50.000000000 +0100 > +++ current/arch/ppc64/Kconfig 2005-05-04 20:54:50.000000000 +0100 > @@ -212,8 +212,8 @@ config ARCH_FLATMEM_ENABLE > source "mm/Kconfig" > > config HAVE_ARCH_EARLY_PFN_TO_NID > - bool > - default y > + def_bool y > + depends on NEED_MULTIPLE_NODES Ok, time to show my lack of undestanding here, but when can we ever be CONFIG_NUMA and NOT need multiple nodes? > @@ -481,6 +483,7 @@ static void __init setup_nonnuma(void) > > for (i = 0 ; i < top_of_ram; i += MEMORY_INCREMENT) > numa_memory_lookup_table[i >> MEMORY_INCREMENT_SHIFT] = 0; > + memory_present(0, 0, init_node_data[0].node_end_pfn); Isn't the memory_present stuff and numa_memory_lookup_table two implementations doing the same thing (mapping memory to nodes)? Can we kill numa_memory_lookup_table with this? -Olof