From: Dave Jones <davej@redhat.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel@vger.kernel.org, Ken Pizzini <ken@halcyon.com>,
Ron Jeppesen <ronj.an@site007.saic.com>,
Corey Minyard <minyard@wf-rch.cirr.com>,
akpm@osdl.org
Subject: Re: [PATCH] remove pointless NULL check before kfree in sony535.c
Date: Fri, 6 May 2005 19:57:22 -0400 [thread overview]
Message-ID: <20050506235722.GB825@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0505070114160.2384@dragon.hyggekrogen.localhost>
On Sat, May 07, 2005 at 01:19:01AM +0200, Jesper Juhl wrote:
> --- linux-2.6.12-rc3-mm3-orig/drivers/cdrom/sonycd535.c 2005-03-02 08:38:37.000000000 +0100
> +++ linux-2.6.12-rc3-mm3/drivers/cdrom/sonycd535.c 2005-05-07 01:13:30.000000000 +0200
> @@ -1605,7 +1605,6 @@ out7:
> put_disk(cdu_disk);
> out6:
> for (i = 0; i < sony_buffer_sectors; i++)
> - if (sony_buffer[i])
> kfree(sony_buffer[i]);
> out5:
This breaks the indentation.
Dave
next prev parent reply other threads:[~2005-05-07 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 23:19 Jesper Juhl
2005-05-06 23:57 ` Dave Jones [this message]
2005-05-07 0:06 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050506235722.GB825@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=juhl-lkml@dif.dk \
--cc=ken@halcyon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@wf-rch.cirr.com \
--cc=ronj.an@site007.saic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®